fix: use default headers in getContents()#2927
Merged
dvikan merged 1 commit intoRSS-Bridge:masterfrom Jul 31, 2022
Merged
Conversation
Contributor
Author
|
I haven't found any bridges which bypasses anti-bot response because of this pr but I think it helps a little but. It also doesn't hurt. These headers will be ignored if using the curl-impersonate library (i think). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this pr is to decrease chance of anti-bot detection.
Modify
getContents()so that it by default uses thefirefox 102headers as suggested by [0]. Tweak_http_request()so that its http headers are passed as an associative array.Unfortunately the http headers as not passed as an associative array to
getContents(). So they must be normalized first and then merged with the default values. Might be some issues regarding header name casing but not doing anything about now.[0] https://github.com/lwthiker/curl-impersonate/blob/main/firefox/curl_ff102