fix: change default curl user agent#2926
Merged
dvikan merged 2 commits intoRSS-Bridge:masterfrom Jul 31, 2022
Merged
Conversation
Pull request artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous ua is
Chrome 74 on Windows 10which is the most common one. The new one in here isfirefox 102which I snagged from https://github.com/lwthiker/curl-impersonate/blob/main/firefox/curl_ff102For some reason I had better luck with this new ua when testing
NovelUpdatesBridge. So maybe we should switch to this new one. The behaviour can possibly be explained by that cloudflare has intimate knowledge on how the chrome 74 on windows 10 acts which is different from the current usage via curl.One issue that remains is that if users have copied
config.default.ini.phptoconfig.ini.phpthe old ua remains in use.EDIT: I also had improvements with SlusheBridge which no longer returned
403 ForbiddenEDIT: Could consider dropping the ua from config in order to prevent the old one from being used in old custom configs.
[0] https://developers.whatismybrowser.com/useragents/parse/#parse-useragent