Integrate curl-impersonate on the Docker file#2925
Closed
somini wants to merge 1 commit intoRSS-Bridge:masterfrom
Closed
Integrate curl-impersonate on the Docker file#2925somini wants to merge 1 commit intoRSS-Bridge:masterfrom
somini wants to merge 1 commit intoRSS-Bridge:masterfrom
Conversation
I don't have much Docker experience, this is just a hack. I also don't know how to use a variable to store the version in a single place, so that we can update it more easily. See RSS-Bridge#2547
Contributor
Author
|
The Dockerfile is not being rebuilt, from what I can tell. So this should not be merged without testing. |
Contributor
|
One of the immediate issues: There is no armv7 build, so this option cant be used in that image. I'll check for normal amd usage now. |
Contributor
|
I proposed (#2941) a similar solution, except by leveraging multi-stage building, which solves the complexity of the system architectures. |
Contributor
|
See #2941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have much Docker experience, this is just a hack.
I also don't know how to use a variable to store the version in a single place, so that we can update it more easily.
See #2547