[GiteaBridge] Add Tags context following for gitea v1.14#2069
Closed
gileri wants to merge 3 commits intoRSS-Bridge:masterfrom
Closed
[GiteaBridge] Add Tags context following for gitea v1.14#2069gileri wants to merge 3 commits intoRSS-Bridge:masterfrom
gileri wants to merge 3 commits intoRSS-Bridge:masterfrom
Conversation
Contributor
Author
|
Hello, is there something missing before this PR is considered ? I just tried it against an up-to-date master and it works fine. |
Contributor
|
You changed from late static binding to static function call? Are you sure that's a refactor? |
dvikan
reviewed
Mar 24, 2022
| protected function setInputs(array $inputs, $queriedContext){ | ||
| // Import and assign all inputs to their context | ||
| foreach($inputs as $name => $value) { | ||
| foreach(static::PARAMETERS as $context => $set) { |
Contributor
|
Also I think this change should go in |
Contributor
|
Make a separate PR if you want to modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for tags with Gitea v1.14.