[Feature] Faster Custom Paged Attention kernels#385
Closed
tjtanaa wants to merge 18 commits intoROCm:llama_fp8_12062024from
Closed
[Feature] Faster Custom Paged Attention kernels#385tjtanaa wants to merge 18 commits intoROCm:llama_fp8_12062024from
tjtanaa wants to merge 18 commits intoROCm:llama_fp8_12062024from
Conversation
Adding build only k8s node and queue names update
- max_seqlens_q/k variables were not correctly initialized for Navi GPUs leading to incorrect outputs. - ensure that the correct values are passed to the attn_fwd kernel based on the GPU type.
…platform (ROCm#313) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…g_attn_to_llama_fp8
adjusted attention kernel unit test.
…g_attn_to_llama_fp8
This was referenced Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a faster Custom Paged Attention (CPA) kernel based on mfma16x16x16 instructions.
This feature is from ROCm/vllm (#372).