Merged
Conversation
New fused_moe configs for Mixtral-8x7B and Mixtral-8x22B with TP=1,2,4,8 for both FP8 and FP16 on the recently announced MI325X.
shajrawi
reviewed
Dec 3, 2024
shajrawi
left a comment
There was a problem hiding this comment.
Can you please make the PR vs develop branch? since that is the one we are currently using and main is frozen at the moment?
Author
Oops, sorry about that. Switched to the develop branch now. |
shajrawi
approved these changes
Dec 3, 2024
shajrawi
left a comment
There was a problem hiding this comment.
Thank you for doing this! Ship it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New fused_moe configs for Mixtral-8x7B and Mixtral-8x22B with TP=1,2,4,8 for both FP8 and FP16 on the recently announced MI325X.