Crop - Tensor implementation on hip and host#83
Conversation
src/include/hip/rpp_hip_common.hpp
Outdated
| #include <hip/hip_runtime.h> | ||
| #include <hip/hip_ext.h> | ||
| #include <hip/hip_fp16.h> | ||
| #include <hip/hcc_detail/hip_vector_types.h> |
There was a problem hiding this comment.
please don't include files from the hcc_detail folder from the hip. including from the hip/hip_fp16 header should give you access to all the HIP's fp16 functionalities.
There was a problem hiding this comment.
Reverted back the headers without hcc_detail
AryanSalmanpour
left a comment
There was a problem hiding this comment.
- @paveltc to verify the unit tests for this PR.
| inline RppStatus rpp_load48_u8pkd3_to_u8pln3(Rpp8u *srcPtr, __m128i *px) | ||
| { | ||
| __m128i pxSrc[8]; | ||
| __m128i pxMask = _mm_setr_epi8(0, 3, 6, 9, 1, 4, 7, 10, 2, 5, 8, 11, 12, 13, 14, 15); |
There was a problem hiding this comment.
I think pxMask and pxMaskRGB is repeatedly used in many functions. Consider defining it as global constant
| } | ||
|
|
||
| // Uncomment to run test case with an ltrbROI override | ||
| /*for (i = 0; i < images; i++) |
There was a problem hiding this comment.
It is better to pass parameters through arguments instead of commenting and uncommenting code.
rrawther
left a comment
There was a problem hiding this comment.
Can me merged after unit-tests pass and approval from @asalmanp
|
@asalmanp @rrawther @r-abishek This PR passes all unit tests. |
@rrawther @asalmanp This PR adds the tensor implementation for crop on hip and host, and the corresponding unit tests and performance tests.