Tensor API - Remove OCL_COMPILE and reformat#82
Merged
kiritigowda merged 2 commits intoROCm:masterfrom Dec 8, 2021
Merged
Conversation
Member
AryanSalmanpour
left a comment
There was a problem hiding this comment.
@r-abishek have you tested this PR with the MIVisionX TOT master branch with both OCL and the HIP backends? Does it build fine with both backends?
Member
Author
|
@asalmanp Yeah, I ran a quick CI test for it for Compatibility check against MIVisionX and the RPP build. The builds for both backends are successful. |
AryanSalmanpour
approved these changes
Dec 7, 2021
rrawther
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rrawther This is a minor PR that removes the OCL_COMPILE flag for tensor versions of RPP, and reformats the API file.