Erode and Dilate - Tensor based optimization for hip#80
Erode and Dilate - Tensor based optimization for hip#80kiritigowda merged 10 commits intoROCm:masterfrom
Conversation
| test_case_name = "erode"; | ||
|
|
||
| Rpp32u kernelSize = additionalParam; | ||
| for (i = 0; i < images; i++) |
There was a problem hiding this comment.
what's the purpose of this for loop here? the entire body of the for loop is commented out!. please remove it here and for all of the new unit tests that have a similar for-loop.
There was a problem hiding this comment.
Modified comment for better clarity on the use case of the ROI override.
There was a problem hiding this comment.
please put the for loop itself into the comment section as well. use /* */ to block the entire block instead of using // to comment on each line. so something like below:
// Uncomment to run test case with an xywhROI override
/* for (i = 0; i < images; i++)
...
...
}*/
| Rpp32u kernelSize = additionalParam; | ||
| for (i = 0; i < images; i++) | ||
| { | ||
| // xywhROI override sample |
| test_case_name = "erode"; | ||
|
|
||
| Rpp32u kernelSize = additionalParam; | ||
| for (i = 0; i < images; i++) |
There was a problem hiding this comment.
please put the for loop itself into the comment section as well. use /* */ to block the entire block instead of using // to comment on each line. so something like below:
// Uncomment to run test case with an xywhROI override
/* for (i = 0; i < images; i++)
...
...
}*/
|
@asalmanp Comments are more organized now - 9a1851b |
AryanSalmanpour
left a comment
There was a problem hiding this comment.
@paveltc please verify this PR by running the RPP unit tests.
|
@asalmanp @kiritigowda @r-abishek This PR passes all of the unit tests. |
@asalmanp This PR contains tensor based optimized erode and dilate implementations for hip.