Dropout (Grid) and Dropout (Cutout) on HIP and HOST by r-abishek · Pull Request #679 · ROCm/rpp

r-abishek · 2026-02-21T01:57:39Z

Adds Grid and Cutout Dropout augmentations on HIP and HOST
Adds support for U8/F32/F16/I8 bit depths and NCHW/NHWC variants with toggle support
Adds relevant unit / qa / performance tests

… HOST AVX, SSE

…ents

…all the bitdepths

…performance

…images in the docs

…opout

… i8 variant

indentation modified

…ied QA for logic to implement random seed for non QA

Copilot

Pull request overview

This PR adds two new tensor image augmentations—Cutout Dropout and Grid Dropout—across HOST and HIP backends, and wires them into the test suite and Doxygen docs.

Changes:

Add rppt_cutout_dropout and rppt_grid_dropout APIs and backend dispatch in rppt_tensor_effects_augmentations.cpp.
Implement Grid Dropout kernels for CPU and HIP, plus test-suite ROI/anchor initializers for Cutout/Grid dropout.
Register new augmentations in the test-suite maps/enums and add HOST/HIP test-case execution paths and doc output assets.

Reviewed changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
utilities/test_suite/rpp_test_suite_image.h	Adds augmentation IDs and introduces Cutout/Grid dropout ROI+anchor initializers for tests.
utilities/test_suite/common.py	Registers new augmentation IDs for test harness routing.
utilities/test_suite/HOST/Tensor_image_host.cpp	Adds HOST-side test cases invoking `rppt_cutout_dropout` / `rppt_grid_dropout`.
utilities/test_suite/HIP/Tensor_image_hip.cpp	Adds HIP-side test cases and allocations for Cutout/Grid dropout.
src/modules/tensor/rppt_tensor_effects_augmentations.cpp	Adds public API entry points and backend dispatch for Cutout/Grid dropout.
src/modules/tensor/hip/kernel/grid_dropout.cpp	Introduces HIP grid-dropout executor and kernels.
src/modules/tensor/cpu/kernel/grid_dropout.cpp	Introduces CPU grid-dropout implementation.
src/include/tensor/host_tensor_executors.hpp	Declares `grid_dropout_host_tensor`.
src/include/tensor/hip_tensor_executors.hpp	Declares `hip_exec_grid_dropout_tensor`.
docs/data/doxygenOutputs/effects_augmentation_gird_dropout_img150x150.png	Adds a Doxygen output image for grid dropout (filename includes a typo).
docs/data/doxygenOutputs/effects_augmentation_cutout_dropout_img150x150.png	Adds a Doxygen output image for cutout dropout.
api/rppt_tensor_effects_augmentations.h	Documents and declares `rppt_cutout_dropout` and `rppt_grid_dropout` APIs.

Comments suppressed due to low confidence (1)

utilities/test_suite/HIP/Tensor_image_hip.cpp:2192

When testCase == GRID_DROPOUT, anchorBoxInfoTensor is allocated with hipHostMalloc, but it is never freed in the cleanup section (the free is gated by testCase == ERASE || testCase == CUTOUT_DROPOUT). Add a corresponding hipHostFree(anchorBoxInfoTensor) for the grid-dropout path (and avoid double-free by structuring ownership clearly).

    if(testCase == ERASE || testCase == CUTOUT_DROPOUT)
    {
        CHECK_RETURN_STATUS(hipHostFree(colorBuffer));
        CHECK_RETURN_STATUS(hipHostFree(anchorBoxInfoTensor));
        CHECK_RETURN_STATUS(hipHostFree(numOfBoxes));
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/modules/tensor/hip/kernel/grid_dropout.cpp

utilities/test_suite/rpp_test_suite_image.h

api/rppt_tensor_effects_augmentations.h

src/modules/tensor/cpu/kernel/grid_dropout.cpp

utilities/test_suite/rpp_test_suite_image.h

utilities/test_suite/HIP/Tensor_image_hip.cpp

api/rppt_tensor_effects_augmentations.h

Grid and cutout dropout - Resolved copilot review comments

codecov · 2026-02-25T02:12:45Z

Codecov Report

❌ Patch coverage is 97.53954% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...dules/tensor/rppt_tensor_effects_augmentations.cpp	95.56%	12 Missing ⚠️
src/modules/tensor/hip/kernel/grid_dropout.cpp	97.75%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #679      +/-   ##
===========================================
- Coverage    92.49%   91.96%   -0.52%     
===========================================
  Files          202      204       +2     
  Lines        91730    92299     +569     
===========================================
+ Hits         84838    84882      +44     
- Misses        6892     7417     +525

Files with missing lines	Coverage Δ
src/modules/tensor/cpu/kernel/grid_dropout.cpp	`100.00% <100.00%> (ø)`
src/modules/tensor/hip/kernel/grid_dropout.cpp	`97.75% <97.75%> (ø)`
...dules/tensor/rppt_tensor_effects_augmentations.cpp	`89.50% <95.56%> (-3.40%)`	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Grid dropout - Added check return status

src/modules/tensor/cpu/kernel/grid_dropout.cpp

src/modules/tensor/hip/kernel/grid_dropout.cpp

rrawther

please address all the review comments

src/modules/tensor/hip/kernel/grid_dropout.cpp

src/modules/tensor/cpu/kernel/grid_dropout.cpp

src/modules/tensor/hip/kernel/grid_dropout.cpp

rrawther

please address review comments

…/rpp into ar/dropout_grid_cutout

snehaa8 and others added 30 commits August 22, 2025 07:39

Optimized version of channel dropout HIP backend and working code for…

e32bbdb

… HOST AVX, SSE

Modified name for dropout compute function

a1fdab1

Modified way of AVX and SSE version channel dropout to avoid if statm…

4c7e1a1

…ents

Modified Channel Dropout with generic compute code reused

5747ea0

Parameters and name change for channel dropout

133236a

Modified HIP for better performance

1fb450e

Modified the code and made the channel dropout templated version for …

63491ac

…all the bitdepths

Modified Erase kernel for grid and cutout dropout version for better …

836ff59

…performance

Modified the .h file to have the dropout to effects and added output …

c9babec

…images in the docs

Added output image and modified the .h file to effects for channel dr…

a374034

…opout

Removed space

f308bbe

added space

709809d

Moved grid dropout .h to effects

938d876

Modified channel dropout for I8 variant HOST side

0bd5686

Resolved all review comments and modified code to produce results for…

751cf48

… i8 variant

Removed empty line

d597022

merged the changes of channel dropout commit to grid, cutout dropout

a0d9ff0

Resolved review comments

4038129

Merge remote-tracking branch 'tot/develop' into apr/channel_dropout

24cada0

Modified HOST after merge

24968cf

Made changes after merging and QA passed for dropout

cbc74c8

Channel dropout make_float 4 macro changes

1baa41e

Updated QA with random generator and updated BIN files

ac97a1e

Modified QA name changes

cd5c576

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout

bc62008

Modified RandomSeed value passed as parameter to the function call

09f993c

Update rppt_tensor_effects_augmentations.cpp

da78859

indentation modified

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout modif…

ed13d97

…ied QA for logic to implement random seed for non QA

Initial modified HIP backend Grid dropout with better performance

3deb6bd

Removed space and review comments resolved

f0e2195

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Resolved copilot review comments

674f0da

LakshmiKumar23 requested a review from AryanSalmanpour February 23, 2026 18:58

kiritigowda and others added 2 commits February 24, 2026 12:21

Merge branch 'develop' into ar/dropout_grid_cutout

75bf2e9

Merge pull request #566 from RooseweltMcW/apr/grid_cutout_dropout

e2463e3

Grid and cutout dropout - Resolved copilot review comments

HazarathKumarM and others added 3 commits March 5, 2026 05:21

Added check return status in grid dropout HIP backend

661317d

Merge pull request #571 from RooseweltMcW/apr/grid_cutout_dropout

c4caf79

Grid dropout - Added check return status

Merge branch 'develop' into ar/dropout_grid_cutout

37151f9

LakshmiKumar23 requested review from msiddaiah March 16, 2026 20:46

msiddaiah reviewed Mar 16, 2026

View reviewed changes

src/modules/tensor/cpu/kernel/grid_dropout.cpp Outdated Show resolved Hide resolved

msiddaiah reviewed Mar 16, 2026

View reviewed changes

src/modules/tensor/hip/kernel/grid_dropout.cpp Outdated Show resolved Hide resolved

rrawther requested changes Mar 16, 2026

View reviewed changes

msiddaiah reviewed Mar 16, 2026

View reviewed changes

src/modules/tensor/hip/kernel/grid_dropout.cpp Show resolved Hide resolved

src/modules/tensor/cpu/kernel/grid_dropout.cpp Show resolved Hide resolved

LakshmiKumar23 and others added 4 commits March 16, 2026 15:13

Merge branch 'develop' into ar/dropout_grid_cutout

8c26e87

resolve review comments

da1b574

fix build errors

d70e0b2

Merge conflicts

00f6345

rrawther reviewed Mar 17, 2026

View reviewed changes

src/modules/tensor/cpu/kernel/grid_dropout.cpp Outdated Show resolved Hide resolved

rrawther reviewed Mar 18, 2026

View reviewed changes

src/modules/tensor/hip/kernel/grid_dropout.cpp Outdated Show resolved Hide resolved

rrawther requested changes Mar 18, 2026

View reviewed changes

HazarathKumarM and others added 4 commits March 18, 2026 10:37

resolve review comments

e3f8d1a

Merge branch 'ar/dropout_grid_cutout' of https://github.com/r-abishek…

df6aa92

…/rpp into ar/dropout_grid_cutout

Merge remote-tracking branch 'develop' into ar/dropout_grid_cutout

ae04a2b

Merge branch 'develop' into ar/dropout_grid_cutout

593a3d5

kiritigowda assigned LakshmiKumar23 and unassigned LakshmiKumar23 Mar 18, 2026

rrawther approved these changes Mar 19, 2026

View reviewed changes

LakshmiKumar23 merged commit 74e2209 into ROCm:develop Mar 23, 2026
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dropout (Grid) and Dropout (Cutout) on HIP and HOST#679

Dropout (Grid) and Dropout (Cutout) on HIP and HOST#679
LakshmiKumar23 merged 139 commits intoROCm:developfrom
r-abishek:ar/dropout_grid_cutout

r-abishek commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

r-abishek commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov bot commented Feb 25, 2026 •

edited

Loading