Dropout (Coarse) on HIP and HOST by r-abishek · Pull Request #676 · ROCm/rpp

r-abishek · 2026-02-20T01:02:11Z

Adds Coarse Dropout augmentation on HIP and HOST
Adds support for U8/F32/F16/I8 bit depths and NCHW/NHWC variants with toggle support
Adds relevant unit / qa / performance tests

… HOST AVX, SSE

…ents

…all the bitdepths

…performance

…images in the docs

…opout

… i8 variant

indentation modified

…ied QA for logic to implement random seed for non QA

Copilot

Pull request overview

This PR introduces a new tensor effects augmentation, coarse_dropout, with both HOST and HIP backend support, and wires it into the test suite and public API documentation.

Changes:

Adds rppt_coarse_dropout() public API and dispatch path (HOST + HIP).
Adds new HOST and HIP kernel implementations for coarse dropout.
Updates test-suite augmentation registries and adds a dropout region initializer + QA/perf hooks.

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
utilities/test_suite/rpp_test_suite_image.h	Registers coarse_dropout and adds `init_dropout_erase()` helper for dropout box generation.
utilities/test_suite/common.py	Adds coarse_dropout to augmentation maps and effect lists for test automation.
utilities/test_suite/HOST/Tensor_image_host.cpp	Adds coarse_dropout execution path in host tensor test runner.
utilities/test_suite/HIP/Tensor_image_hip.cpp	Adds coarse_dropout execution path and pinned allocations in HIP tensor test runner.
src/modules/tensor/rppt_tensor_effects_augmentations.cpp	Adds `rppt_coarse_dropout()` entrypoint and backend dispatch.
src/modules/tensor/hip/kernel/coarse_dropout.cpp	Adds HIP kernels + executor for coarse dropout.
src/modules/tensor/cpu/kernel/coarse_dropout.cpp	Adds HOST kernel implementation for coarse dropout.
src/include/tensor/host_tensor_executors.hpp	Declares `coarse_dropout_host_tensor()` executor template.
src/include/tensor/hip_tensor_executors.hpp	Declares `hip_exec_coarse_dropout_tensor()` executor template.
docs/data/doxygenOutputs/effects_augmentation_coarse_dropout_img150x150.png.jpg	Adds documentation sample output asset for coarse dropout.
api/rppt_tensor_effects_augmentations.h	Documents and exposes `rppt_coarse_dropout()` in the public header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utilities/test_suite/rpp_test_suite_image.h

src/modules/tensor/hip/kernel/coarse_dropout.cpp

src/modules/tensor/cpu/kernel/coarse_dropout.cpp

utilities/test_suite/rpp_test_suite_image.h

src/modules/tensor/hip/kernel/coarse_dropout.cpp

src/modules/tensor/cpu/kernel/coarse_dropout.cpp

api/rppt_tensor_effects_augmentations.h

utilities/test_suite/rpp_test_suite_image.h

codecov · 2026-02-20T02:39:05Z

Codecov Report

❌ Patch coverage is 97.84483% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...dules/tensor/rppt_tensor_effects_augmentations.cpp	95.49%	6 Missing ⚠️
src/modules/tensor/hip/kernel/coarse_dropout.cpp	96.33%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
+ Coverage    91.97%   92.54%   +0.56%     
===========================================
  Files          204      206       +2     
  Lines        92299    92763     +464     
===========================================
+ Hits         84892    85841     +949     
+ Misses        7407     6922     -485

Files with missing lines	Coverage Δ
src/modules/tensor/cpu/kernel/coarse_dropout.cpp	`100.00% <100.00%> (ø)`
src/modules/tensor/hip/kernel/coarse_dropout.cpp	`96.33% <96.33%> (ø)`
...dules/tensor/rppt_tensor_effects_augmentations.cpp	`93.22% <95.49%> (+3.72%)`	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Coarse Dropout - Resolved Copilot review comments

src/modules/tensor/cpu/kernel/coarse_dropout.cpp

src/modules/tensor/hip/kernel/coarse_dropout.cpp

rrawther

Please address the review comments

utilities/test_suite/rpp_test_suite_image.h

src/modules/tensor/cpu/kernel/coarse_dropout.cpp

rrawther

Some comments are still not resolved. PLease resolve all including copilot

…into ar/dropout_coarse

HazarathKumarM · 2026-03-24T02:45:32Z

Some comments are still not resolved. PLease resolve all including copilot

comments are all resolved now

snehaa8 and others added 30 commits August 22, 2025 07:39

Optimized version of channel dropout HIP backend and working code for…

e32bbdb

… HOST AVX, SSE

Modified name for dropout compute function

a1fdab1

Modified way of AVX and SSE version channel dropout to avoid if statm…

4c7e1a1

…ents

Modified Channel Dropout with generic compute code reused

5747ea0

Parameters and name change for channel dropout

133236a

Modified HIP for better performance

1fb450e

Modified the code and made the channel dropout templated version for …

63491ac

…all the bitdepths

Modified Erase kernel for grid and cutout dropout version for better …

836ff59

…performance

Modified the .h file to have the dropout to effects and added output …

c9babec

…images in the docs

Added output image and modified the .h file to effects for channel dr…

a374034

…opout

Removed space

f308bbe

added space

709809d

Moved grid dropout .h to effects

938d876

Modified channel dropout for I8 variant HOST side

0bd5686

Resolved all review comments and modified code to produce results for…

751cf48

… i8 variant

Removed empty line

d597022

merged the changes of channel dropout commit to grid, cutout dropout

a0d9ff0

Resolved review comments

4038129

Merge remote-tracking branch 'tot/develop' into apr/channel_dropout

24cada0

Modified HOST after merge

24968cf

Made changes after merging and QA passed for dropout

cbc74c8

Channel dropout make_float 4 macro changes

1baa41e

Updated QA with random generator and updated BIN files

ac97a1e

Modified QA name changes

cd5c576

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout

bc62008

Modified RandomSeed value passed as parameter to the function call

09f993c

Update rppt_tensor_effects_augmentations.cpp

da78859

indentation modified

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout modif…

ed13d97

…ied QA for logic to implement random seed for non QA

Initial modified HIP backend Grid dropout with better performance

3deb6bd

Removed space and review comments resolved

f0e2195

r-abishek requested a review from Copilot February 20, 2026 01:02

r-abishek added the ci:precheckin label Feb 20, 2026

Copilot started reviewing on behalf of r-abishek February 20, 2026 01:04 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

HazarathKumarM and others added 2 commits February 20, 2026 01:53

Resolved review comments and updated bin files

64cd8e6

Merge pull request #565 from RooseweltMcW/apr/coarse_dropout

4f14c37

Coarse Dropout - Resolved Copilot review comments

LakshmiKumar23 requested a review from AryanSalmanpour February 23, 2026 18:58

r-abishek and others added 2 commits February 24, 2026 16:28

Merge branch 'develop' into ar/dropout_coarse

b7a27d7

Merge branch 'develop' into ar/dropout_coarse

919f1d1

LakshmiKumar23 requested review from msiddaiah March 16, 2026 20:47

rrawther reviewed Mar 16, 2026

View reviewed changes

src/modules/tensor/cpu/kernel/coarse_dropout.cpp Show resolved Hide resolved

rrawther requested changes Mar 16, 2026

View reviewed changes

src/modules/tensor/hip/kernel/coarse_dropout.cpp Show resolved Hide resolved

rrawther reviewed Mar 16, 2026

View reviewed changes

msiddaiah reviewed Mar 16, 2026

View reviewed changes

utilities/test_suite/rpp_test_suite_image.h Outdated Show resolved Hide resolved

utilities/test_suite/rpp_test_suite_image.h Outdated Show resolved Hide resolved

HazarathKumarM and others added 4 commits March 17, 2026 12:35

resolve review comments

7d960e7

Merge remote-tracking branch 'develop' into ar/dropout_coarse

9aa8209

fixed QA issues

46c52aa

Merge branch 'develop' into ar/dropout_coarse

cab8ceb

rrawther reviewed Mar 17, 2026

View reviewed changes

src/modules/tensor/cpu/kernel/coarse_dropout.cpp Outdated Show resolved Hide resolved

fix build errors post merge

5be272b

kiritigowda assigned LakshmiKumar23 Mar 18, 2026

Merge branch 'develop' into ar/dropout_coarse

493916b

rrawther requested changes Mar 19, 2026

View reviewed changes

HazarathKumarM added 2 commits March 23, 2026 22:44

Merge remote-tracking branch 'develop' into ar/dropout_coarse

01548fb

Merge branch 'ar/dropout_coarse' of https://github.com/r-abishek/rpp …

e9a26ce

…into ar/dropout_coarse

rrawther approved these changes Mar 24, 2026

View reviewed changes

LakshmiKumar23 merged commit 2f8d950 into ROCm:develop Mar 24, 2026
6 checks passed

Conversation

r-abishek commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

HazarathKumarM commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Feb 20, 2026 •

edited

Loading