RPP Tensor Fisheye on HOST and HIP#654
Merged
kiritigowda merged 41 commits intoROCm:developfrom Jan 22, 2026
Merged
Conversation
Contributor
Srihari-mcw
commented
Dec 22, 2025
- Adds Fisheye augmentation on HIP and HOST
- Adds support for U8/F32/F16/I8 bit depths and NCHW/NHWC variants with toggle support
- Adds relevant unit / qa / performance tests
consolidated the code
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds fisheye lens distortion augmentation support for both HIP (GPU) and HOST (CPU) backends. The implementation supports multiple data types (U8, F16, F32, I8) and layout formats (NCHW, NHWC) with layout conversion capabilities.
Key Changes
- Added fisheye augmentation kernel implementations for HIP and HOST
- Integrated fisheye into test suites with appropriate test case ID (25)
- Added API documentation with sample input/output images
- Implemented AVX2-optimized SIMD code paths for CPU execution
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/rpp_test_suite_image.h | Added fisheye enum entry (FISHEYE = 25) and augmentation map entry |
| utilities/test_suite/common.py | Added fisheye to test configuration with HOST and HIP backend support, categorized as geometric augmentation |
| utilities/test_suite/HOST/Tensor_image_host.cpp | Added HOST test case for fisheye supporting U8/F16/F32/I8 data types |
| utilities/test_suite/HIP/Tensor_image_hip.cpp | Added HIP test case for fisheye supporting U8/F16/F32/I8 data types |
| src/modules/tensor/rppt_tensor_geometric_augmentations.cpp | Implemented rppt_fisheye_host and rppt_fisheye_gpu API functions with data type dispatching |
| src/modules/tensor/hip/kernel/fisheye.cpp | New HIP kernel implementation with device helpers and layout-specific kernels |
| src/modules/tensor/cpu/kernel/fisheye.cpp | New CPU kernel implementation with AVX2 optimizations and scalar fallback |
| src/include/tensor/host_tensor_executors.hpp | Added function declarations for fisheye HOST implementations |
| src/include/tensor/hip_tensor_executors.hpp | Added template function declaration for fisheye HIP implementation |
| src/include/common/cpu/rpp_cpu_simd_load_store.hpp | Added new AVX constants (avx_pMinus1, avx_p1op2) for fisheye computations |
| api/rppt_tensor_geometric_augmentations.h | Added comprehensive API documentation for rppt_fisheye_host and rppt_fisheye_gpu |
| docs/data/doxygenOutputs/geometric_augmentations_fisheye_img150x150.png | Added sample output image for documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rrawther
reviewed
Jan 12, 2026
rrawther
reviewed
Jan 12, 2026
rrawther
requested changes
Jan 12, 2026
rrawther
approved these changes
Jan 21, 2026
AryanSalmanpour
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.