Channel Permute - Addition of 'permutationsList' argument by r-abishek · Pull Request #547 · ROCm/rpp

r-abishek · 2025-04-22T23:21:07Z

The PR adds one argument to already existent swap_channels augmentation.
The new "permutationTensor" argument takes in any permutation to permute the RGB channels in any order.
Name of the function has been changed to channel_permute since swap_channels indicated only two channels being swapped.

Extend tensor support of channel_permute augmentation for all permutations with AVX2 on HOST backend.
Extend tensor support of channel_permute augmentation for all permutations on HIP backend.
Add relevant unit and performance tests.

…annel

…Permute RPP Tensor Support - Swap channels on HOST and HIP

Copilot

Pull Request Overview

This PR extends the swap_channels augmentation to support all possible RGB channel permutations by introducing a new "permTensor" argument, which is propagated through both the HOST and HIP backends and reflected in the associated tests.

Added the new "permTensor" argument to swap_channels functions and updated kernels in both host and HIP code.
Updated unit and performance test scripts on HOST and HIP to loop over all six channel permutation orders.
Modified interface declarations and API documentation to include the new parameter.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
utilities/test_suite/rpp_test_suite_image.h	Added SWAP_CHANNELS to additionalParamCases and branch for perm order string generation; introduced fill_perm_values for permutation setup.
utilities/test_suite/HOST/runImageTests.py	Added new test branch (case "85") to iterate over all swap orders for host tests.
utilities/test_suite/HOST/Tensor_image_host.cpp	Updated swap_channels calls to pass the permTensor and adjusted function naming accordingly.
utilities/test_suite/HIP/runImageTests.py	Added new test branch (case "85") to iterate over swap orders for HIP tests.
utilities/test_suite/HIP/Tensor_image_hip.cpp	Allocates and frees permTensor, and updates swap_channels GPU calls to include permTensor.
src/modules/tensor/rppt_tensor_data_exchange_operations.cpp	Updated swap_channels function signatures to include the new permTensor parameter.
src/modules/tensor/hip/kernel/swap_channels.cpp	Updated device kernel functions to pass permTensor to the swap_channels_hip_compute routine.
src/include/tensor/host_tensor_executors.hpp and src/include/tensor/hip_tensor_executors.hpp	Updated function declarations to include permTensor.
api/rppt_tensor_data_exchange_operations.h	Updated API documentation and function prototypes to include the new permTensor parameter.

utilities/test_suite/rpp_test_suite_image.h

utilities/test_suite/HOST/Tensor_image_host.cpp

codecov · 2025-04-23T00:50:57Z

Codecov Report

❌ Patch coverage is 97.66234% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/modules/tensor/cpu/kernel/channel_permute.cpp	97.21%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #547      +/-   ##
===========================================
+ Coverage    54.81%   54.84%   +0.03%     
===========================================
  Files          293      293              
  Lines       118454   118516      +62     
===========================================
+ Hits         64921    64994      +73     
+ Misses       53533    53522      -11

Files with missing lines	Coverage Δ
src/modules/tensor/hip/kernel/channel_permute.cpp	`100.00% <100.00%> (ø)`
...es/tensor/rppt_tensor_data_exchange_operations.cpp	`93.75% <100.00%> (+0.18%)`	⬆️
src/modules/tensor/cpu/kernel/channel_permute.cpp	`97.52% <97.21%> (ø)`

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

spolifroni-amd

The changelog line needs some context.

CHANGELOG.md

…nsor computation

…Permute RPP Channel Permute : Modified swap channels as Channel Permute

Copilot

Pull Request Overview

This PR renames the existing swap_channels augmentation to channel_permute and adds a new permTensor argument to allow any permutation of the RGB channels. Key changes include updating API functions for both HOST and HIP backends, modifying test suite cases and scripts, and updating related documentation and changelog entries.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
utilities/test_suite/rpp_test_suite_image.h	Renamed augmentation key from "swap_channels" to "channel_permute"
utilities/test_suite/common.py	Updated augmentation name to channel_permute in test mapping
utilities/test_suite/HOST/runImageTests.py	Modified test invocation to iterate over 6 permutation orders
utilities/test_suite/HOST/Tensor_image_host.cpp	Updated function name and handling for channel_permute augmentation
utilities/test_suite/HIP/runImageTests.py	Updated test invocation for HIP backend using new channel_permute logic
utilities/test_suite/HIP/Tensor_image_hip.cpp	Updated function name, parameter handling and memory management for channel_permute augmentation
src/modules/tensor/rppt_tensor_data_exchange_operations.cpp	Renamed API functions and added the new permTensor parameter in host and GPU implementations
src/include/tensor/host_tensor_executors.hpp and hip_tensor_executors.hpp	Updated declarations and documentation to reflect channel_permute changes
api/rppt_tensor_data_exchange_operations.h	Updated API comments and function signature to include the new permTensor parameter
CHANGELOG.md	Documented change to the API of the swap_channels augmentation

Comments suppressed due to low confidence (1)

utilities/test_suite/HOST/runImageTests.py:88

[nitpick] Consider renaming the local variable 'swapOrder' to 'permOrder' in the test scripts for clarity and to better reflect the updated channel_permute functionality.

for swapOrder in range(swapOrderRange):

utilities/test_suite/HOST/Tensor_image_host.cpp

rrawther

Added comments. Main idea is get rid of permutelist and take the permute channel order directly so the API will be more transparent to the user

CHANGELOG.md

api/rppt_tensor_data_exchange_operations.h

src/modules/tensor/cpu/kernel/channel_permute.cpp

src/include/tensor/hip_tensor_executors.hpp

…Permute Random Channel Permute : Resolved review comments

HazarathKumarM and others added 16 commits January 26, 2025 11:20

Initial version for random channel permute for HOST

c64c0ab

Implimented random channel permute for remaining bit depth on HOST

c00569a

Initial concat implementation for HIp

21660c2

Removed random channel permute implimentation and merged with swap ch…

65c7dda

…annel

deleted random channel permute kernel

c91c23b

Golden output added for all variant of swap channel

30de3d0

Minor changes

b671433

Minor changes

0dfbfa9

Changed from simd to AVX

d575067

Small changes in comments

0910b8e

Optimized for pkd variant

c2ce79e

Merge latest changes

b86571e

Fix Build errors and QA tests

d26538d

resolved review comments

3c6225e

Add F32 bin files and fix Pkd3-Pkd3 QA tests

68cc6d1

Merge pull request #400 from Dineshbabu-Ravichandran/db/randomChannel…

acecafe

…Permute RPP Tensor Support - Swap channels on HOST and HIP

r-abishek added enhancement New feature or request ci:precheckin labels Apr 22, 2025

r-abishek requested a review from Copilot April 22, 2025 23:21

Copilot AI reviewed Apr 22, 2025

View reviewed changes

utilities/test_suite/rpp_test_suite_image.h Show resolved Hide resolved

utilities/test_suite/HOST/Tensor_image_host.cpp Outdated Show resolved Hide resolved

Update CHANGELOG.md

b8f5e15

r-abishek requested a review from a team as a code owner April 22, 2025 23:23

spolifroni-amd requested changes Apr 23, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

HazarathKumarM added 2 commits April 28, 2025 17:07

Modified swap channels as channel permute and modified permutation te…

e3b2114

…nsor computation

minor changes

3a10246

kiritigowda self-assigned this Apr 29, 2025

Merge pull request #428 from Dineshbabu-Ravichandran/db/randomChannel…

cec7dd6

…Permute RPP Channel Permute : Modified swap channels as Channel Permute

r-abishek changed the title ~~Swap Channels - Addition of 'permTensor' argument~~ Channel Permute - Addition of 'permTensor' argument Apr 29, 2025

r-abishek requested a review from Copilot April 29, 2025 19:28

Copilot AI reviewed Apr 29, 2025

View reviewed changes

utilities/test_suite/HOST/Tensor_image_host.cpp Show resolved Hide resolved

Update CHANGELOG.md

56cb747

r-abishek changed the title ~~Channel Permute - Addition of 'permTensor' argument~~ Channel Permute - Addition of 'permutationsList' argument Apr 30, 2025

spolifroni-amd approved these changes Apr 30, 2025

View reviewed changes

kiritigowda added 3 commits April 30, 2025 10:33

Merge branch 'develop' into ar/opt_swap_channels

471b1c5

Merge branch 'develop' into ar/opt_swap_channels

e61a788

Merge branch 'develop' into ar/opt_swap_channels

6b6b275

rrawther requested changes May 5, 2025

View reviewed changes

HazarathKumarM and others added 5 commits May 8, 2025 16:42

change permutation lists changes

7ca1b80

updated comments for better readability

ab1d899

Merge pull request #432 from Dineshbabu-Ravichandran/db/randomChannel…

e2b7127

…Permute Random Channel Permute : Resolved review comments

Update CHANGELOG.md

5bf56b4

Change swap to permute

947979f

rrawther approved these changes May 14, 2025

View reviewed changes

rrawther merged commit e792fd0 into ROCm:develop May 14, 2025
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Channel Permute - Addition of 'permutationsList' argument#547

Channel Permute - Addition of 'permutationsList' argument#547
rrawther merged 29 commits intoROCm:developfrom
r-abishek:ar/opt_swap_channels

r-abishek commented Apr 22, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

spolifroni-amd left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

r-abishek commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

spolifroni-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

r-abishek commented Apr 22, 2025 •

edited

Loading

codecov bot commented Apr 23, 2025 •

edited

Loading