RPP Concat for HOST and HIP#530
Merged
kiritigowda merged 231 commits intoROCm:developfrom Apr 9, 2025
Merged
Conversation
Member
r-abishek
commented
Mar 25, 2025
- Add tensor support for Concat Augmentation optimized using AVX2 on HOST backend.
- Add tensor support for Concat Augmentation on HIP backend.
- Add relevant unit and performance tests support for Concat augmentation in test suite.
Hip host build parallelized
…nto hk/concat_hip
RPP Tensor Support - Concat on HOST and HIP
spolifroni-amd
requested changes
Mar 25, 2025
Contributor
spolifroni-amd
left a comment
There was a problem hiding this comment.
Changelog needs a bit of clarification.
Also: does this require documentation?
spolifroni-amd
approved these changes
Mar 26, 2025
Collaborator
|
@r-abishek - failing CI |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tensor support for the Concat augmentation on both HOST and HIP backends, along with updated unit and performance tests. Key changes include:
- Updating augmentation maps and test cases to include a new concat option.
- Modifying test command functions in HOST and HIP to pass an additional bitDepth parameter.
- Extending the test suite parser to handle the new case "3" with appropriate axis mask ranges.
Reviewed Changes
Copilot reviewed 12 out of 23 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utilities/test_suite/common.py | Added "concat" augmentation to the miscAugmentationMap. |
| utilities/test_suite/HOST/runMiscTests.py | Adjusted test ranges and subprocess calls to support tensor-based concat tests. |
| utilities/test_suite/HIP/runMiscTests.py | Updated test commands and profiler commands to include bitDepth parameter. |
| CHANGELOG.md | Updated changelog with new tensor concat augmentation support. |
Files not reviewed (11)
- api/rppdefs.h: Language not supported
- api/rppt_tensor_geometric_augmentations.h: Language not supported
- src/include/common/cpu/rpp_cpu_simd_load_store.hpp: Language not supported
- src/include/tensor/hip_tensor_executors.hpp: Language not supported
- src/include/tensor/host_tensor_executors.hpp: Language not supported
- src/modules/tensor/cpu/kernel/gaussian_filter.cpp: Language not supported
- src/modules/tensor/hip/kernel/concat.cpp: Language not supported
- src/modules/tensor/rppt_tensor_geometric_augmentations.cpp: Language not supported
- utilities/test_suite/HIP/Tensor_misc_hip.cpp: Language not supported
- utilities/test_suite/HOST/Tensor_misc_host.cpp: Language not supported
- utilities/test_suite/rpp_test_suite_misc.h: Language not supported
Comments suppressed due to low confidence (2)
utilities/test_suite/HOST/runMiscTests.py:51
- [nitpick] Consider extracting the hardcoded bit depth range (range(7)) into a named constant to improve maintainability and clarity.
bitDepths = range(7)
utilities/test_suite/HIP/runMiscTests.py:78
- [nitpick] Consider extracting the hardcoded bit depth range (range(7)) into a named constant for improved readability and maintainability.
bitDepths = range(7)
AryanSalmanpour
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.