Deps update: Support turbojpeg package#296
Merged
kiritigowda merged 8 commits intoROCm:developfrom Mar 14, 2025
Merged
Conversation
Contributor
SundarRajan28
commented
Mar 5, 2025
- Removes usage of tj3GetScalingFactors API which is only present in turbojpeg v3.0 and above
- Tested rocAL unit tests and trainings to ensure accuracy and performance on par with turbojpeg source install
rrawther
previously approved these changes
Mar 6, 2025
Collaborator
|
@SundarRajan28 can you update the setup install and readme instructions in this PR? |
Contributor
Author
|
@kiritigowda I have added the libturbojpeg0-dev ubuntu package in readme and rocAL-setup.py. For RHEL9/CentOS/Oracle linux, I am finding different package names which requires enabling repos during package install. Can we keep the source install for non-ubuntu OS until we find a solution? |
Collaborator
|
@SundarRajan28 - rpm package |
LakshmiKumar23
previously approved these changes
Mar 10, 2025
spolifroni-amd
previously approved these changes
Mar 10, 2025
rrawther
reviewed
Mar 10, 2025
rrawther
reviewed
Mar 10, 2025
a5aa853
Contributor
Author
|
@kiritigowda Added the turbojpeg-devel package in rocAL-setup.py and updated the changelog accordingly |
LakshmiKumar23
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.