Skip to content

[release/2.5] [ROCm][TunableOp] Future proof TunableOp unit test.#1894

Merged
pruthvistony merged 1 commit intorelease/2.5from
release/2.5_fix_tunableop_test_future_rocm
Feb 12, 2025
Merged

[release/2.5] [ROCm][TunableOp] Future proof TunableOp unit test.#1894
pruthvistony merged 1 commit intorelease/2.5from
release/2.5_fix_tunableop_test_future_rocm

Conversation

@naromero77amd
Copy link

Note that I had to copy and paste this one line change because the file has changed so much that the cherry-pick command fails.

TunableOp UT will fail because the regular expression in the test will not work for future versions of ROCm.

Pull Request resolved: pytorch#146548
Approved by: https://github.com/jeffdaily

@naromero77amd naromero77amd changed the title [release/2.5] [ROCm][TunableOp] Close offline tuning results file when offline tuning is disabled. [release/2.5] [ROCm][TunableOp] Future proof TunableOp unit test. Feb 11, 2025
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 11, 2025

Jenkins build for 146ca080a25dfdc8895a03fce519ab0146a98fc0 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@pruthvistony pruthvistony merged commit 38c8279 into release/2.5 Feb 12, 2025
0 of 2 checks passed
@pruthvistony pruthvistony deleted the release/2.5_fix_tunableop_test_future_rocm branch February 12, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants