[release/2.5] [ROCm][TunableOp] Future proof TunableOp unit test.#1894
Merged
pruthvistony merged 1 commit intorelease/2.5from Feb 12, 2025
Merged
Conversation
|
Jenkins build for 146ca080a25dfdc8895a03fce519ab0146a98fc0 commit finished as FAILURE |
pruthvistony
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I had to copy and paste this one line change because the file has changed so much that the cherry-pick command fails.
TunableOp UT will fail because the regular expression in the test will not work for future versions of ROCm.
Pull Request resolved: pytorch#146548
Approved by: https://github.com/jeffdaily