Skip to content

[release/2.5] Navi fixes#1885

Merged
pruthvistony merged 4 commits intorelease/2.5from
dnikolev/release2.5-navi4x-fixes
Feb 19, 2025
Merged

[release/2.5] Navi fixes#1885
pruthvistony merged 4 commits intorelease/2.5from
dnikolev/release2.5-navi4x-fixes

Conversation

@dnikolaev-amd
Copy link

@dnikolaev-amd dnikolaev-amd commented Feb 6, 2025 •
edited
Loading

all Inductor tests completely disabled for Navi4

  • test_sparse_csr.py::TestSparseCompressedTritonKernelsCUDA::test_triton_bsr_scatter_mm_*_cuda_bfloat16 - skipped on Navi due to triton bf16 to fp16 conversion error
  • test_jit.py::TestFrozenOptimizations::test_freeze_conv_relu_fusion* - skipped on Navi4, not supported by MIOpen
  • nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_cudnn_convolution_relu_cuda_float32 - skipped on Navi4, not supported by MIOpen
  • profiler/test_cpp_thread.py::CppThreadTest::test_without_enable_profiler_in_child_thread - flaky on Navi
  • test_ops.py::TestCommonCUDA::test_non_standard_bool_values_*
  • dynamo/test_activation_checkpointing.py::ActivationCheckpointingViaTagsTests::test_pattern_matcher

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 7, 2025 •
edited
Loading

Jenkins build for e94f0a7f708dcf5e311e20de6d453d1ce740245e commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@dnikolaev-amd dnikolaev-amd marked this pull request as ready for review February 19, 2025 21:23
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 19, 2025 •
edited
Loading

Jenkins build for 96564d88e99f7e62f556c30a4f4141cef4768858 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

pruthvistony
pruthvistony approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inductor is NOT support on Navi4x in torch/2.5.

@pruthvistony pruthvistony merged commit a07b6bf into release/2.5 Feb 19, 2025
0 of 2 checks passed
@pruthvistony pruthvistony deleted the dnikolev/release2.5-navi4x-fixes branch February 19, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pruthvistony pruthvistony pruthvistony approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnikolaev-amd @pruthvistony