Skip to content

[release/2.5] [ROCm] fastSpecializedAtomicAdd for MI300 (#135770)#1746

Merged
jithunnair-amd merged 1 commit intorelease/2.5from
release_2.5_cp_135770
Nov 23, 2024
Merged

[release/2.5] [ROCm] fastSpecializedAtomicAdd for MI300 (#135770)#1746
jithunnair-amd merged 1 commit intorelease/2.5from
release_2.5_cp_135770

Conversation

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

@jithunnair-amd jithunnair-amd commented Nov 23, 2024

MI300 adds HW support for packed bfloat16 and fp16. Enable via existing fastSpecializedAtomicAdd.

Helps with improving torch.scatter_add_ performance, among others.

Pull Request resolved: pytorch#135770

MI300 adds HW support for packed bfloat16 and fp16. Enable via existing fastSpecializedAtomicAdd.

Pull Request resolved: pytorch#135770
Approved by: https://github.com/xw285cornell, https://github.com/jianyuh

(cherry picked from commit d33a5e2)
@jithunnair-amd jithunnair-amd merged commit c3ba1e8 into release/2.5 Nov 23, 2024
@jithunnair-amd jithunnair-amd deleted the release_2.5_cp_135770 branch November 23, 2024 09:03
@ROCm ROCm deleted a comment from rocm-mici Nov 25, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@ROCm ROCm deleted a comment from rocm-mici Nov 26, 2024
@inemankov
Copy link
Copy Markdown

cherry-pick -onto release/2.4

@rocm-mici
Copy link
Copy Markdown

rocm-mici commented Nov 26, 2024

Created branch release/2.4_cherry-pick_pr-1746. It contains a merge conflict. Please resolve it

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Created branch release/2.4_cherry-pick_pr-1746 and #1769. It contains a merge conflict. Please resolve it

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Can't perform the cherry-pick keyword: unexpected error

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Can't perform the cherry-pick keyword: unexpected error

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Created branch release/2.4_cherry-pick_pr-1746 and null. It contains a merge conflict. Please resolve it

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Created branch release/2.4_cherry-pick_pr-1746 and null. It contains a merge conflict. Please resolve it

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Can't perform the cherry-pick keyword: unexpected error

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Can't perform the cherry-pick keyword: unexpected error

@inemankov
Copy link
Copy Markdown

cherry-pick --onto release/2.4

@rocm-mici
Copy link
Copy Markdown

Created branch release/2.4_cherry-pick_pr-1746 and #1774. It contains a merge conflict. Please resolve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants