Skip to content

[release/2.5] remove amax_ptr from scaled_gemm (#135421)#1741

Merged
jithunnair-amd merged 1 commit intorelease/2.5from
release/2.5-cp-pr135421
Nov 21, 2024
Merged

[release/2.5] remove amax_ptr from scaled_gemm (#135421)#1741
jithunnair-amd merged 1 commit intorelease/2.5from
release/2.5-cp-pr135421

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Nov 21, 2024

amax was removed from _scaled_mm by pytorch#128683. Remove it from the internal at::cuda::blas::scaled_gemm, as well. This allows hipBLASLt to find additional solutions rather than forcing amax to be used and then discarding the result. Pull Request resolved: pytorch#135421 Approved by: https://github.com/drisspg, https://github.com/eqy

@jeffdaily
remove amax_ptr from scaled_gemm (pytorch#135421)
312b994 
amax was removed from _scaled_mm by pytorch#128683. Remove it from the internal at::cuda::blas::scaled_gemm, as well.  This allows hipBLASLt to find additional solutions rather than forcing amax to be used and then discarding the result.
Pull Request resolved: pytorch#135421
Approved by: https://github.com/drisspg, https://github.com/eqy
@jeffdaily jeffdaily changed the title remove amax_ptr from scaled_gemm (#135421) [release/2.5] remove amax_ptr from scaled_gemm (#135421) Nov 21, 2024
@okakarpa
Copy link
Collaborator

okakarpa commented Nov 21, 2024

Jenkins build for 312b994524d53ae991b146260e9cd7d94a106c7e commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Detected error during Pytorch building:

/opt/rocm-6.2.3/lib/llvm/bin/../../../include/hip/hip_runtime_api.h:580:41: note: expanded from macro 'DEPRECATED'
  580 | #define DEPRECATED(msg) __attribute__ ((deprecated(msg)))
      |                                         ^
1 warning generated when compiling for gfx908.
[7977/8668] Building HIPCC object caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/torch_hip_generated_flash_api.hip.o
FAILED: caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/torch_hip_generated_flash_api.hip.o /var/lib/jenkins/pytorch/build/caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/torch_hip_generated_flash_api.hip.o 
cd /var/lib/jenkins/pytorch/build/caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn && /opt/conda/envs/py_3.10/bin/cmake -E make_directory /var/lib/jenkins/pytorch/build/caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/. && /opt/conda/envs/py_3.10/bin/cmake -D verbose:BOOL=OFF -D build_configuration:STRING=RELEASE -D generated_file:STRING=/var/lib/jenkins/pytorch/build/caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/./torch_hip_generated_flash_api.hip.o -P /var/lib/jenkins/pytorch/build/caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/transformers/hip/flash_attn/torch_hip_generated_flash_api.hip.o.cmake
In file included from /var/lib/jenkins/pytorch/aten/src/ATen/native/transformers/hip/flash_attn/flash_api.hip:57:
/var/lib/jenkins/pytorch/aten/src/ATen/native/transformers/hip/aotriton_adapter.h:120:10: error: no matching constructor for initialization of 'aotriton::TensorView<0>'
  120 |   return aotriton::TensorView<0>(reinterpret_cast<intptr_t>(q.data_ptr()),
      |          ^                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@jithunnair-amd jithunnair-amd merged commit 49c8b69 into release/2.5 Nov 21, 2024
@jithunnair-amd jithunnair-amd deleted the release/2.5-cp-pr135421 branch November 21, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

@jpvillam-amd jpvillam-amd Awaiting requested review from jpvillam-amd

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffdaily @okakarpa @jithunnair-amd