[release/2.3] [ROCM] Properly disable Flash Attention/Efficient Attention with environment variables#1571
Merged
pruthvistony merged 6 commits intorelease/2.3from Sep 11, 2024
Merged
Conversation
pruthvistony
reviewed
Sep 9, 2024
| "Mem Efficient attention was not compiled for current AMD GPU architecture. Attempting to run on architecture ", dprops->gcnArchName); | ||
| } | ||
| return false; | ||
| } |
Collaborator
There was a problem hiding this comment.
@pruthvistony Isn't this where we would need to add a return true to address the "Control reaching end of non-void function" error?
Collaborator
|
For 2.3 mem_efficient should always be false. |
56f999f to
2c4693b
Compare
pruthvistony
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
USE_FLASH_ATTENTION=0 USE_MEM_EFF_ATTENTION=0 python setup.pycan compile correctly.This is cherry-picked version of pytorch#133866