Skip to content

[Detectron] Incorrect use of max and abs #297

@ashishfarmer

Description

@ashishfarmer

After enabling Detectron files hipification and building in PR #295, there are warnings while building the project from the following files:
sigmoid_focal_loss_op_hip.cc
ps_roi_pool_op_hip.cc
smooth_l1_loss_op_hip.cc
The warnings are because HIP does not overload max and abs functions.

Please add appropriate checks #if defined (__HIP_PLATFORM_HCC__) and use more specific HIP functions like fmaxf and fabsfin the corresponding CUDA files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions