Mark copied git repo as a safe directory (#114)#115
Merged
diptorupd merged 1 commit intorelease/0.2.5+amd.2from Jan 13, 2026
Merged
Mark copied git repo as a safe directory (#114)#115diptorupd merged 1 commit intorelease/0.2.5+amd.2from
diptorupd merged 1 commit intorelease/0.2.5+amd.2from
Conversation
The rocm ci build system fetches the git repo separately and then copies it into the final docker image. Both steps use different uids that causes git to fail inside the docker image due to invalid directory ownership issues. A corollary of `git` failing is that our wheel versioning that depends on `git describe` fails and we end up with `0.0.0` as the fallback version. The PR adds a `RUN git config --global --add safe.directory /root/flashinfer` step in our CI docker file to temporarily workaround the issue.
demandal25
approved these changes
Jan 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses a git ownership issue in the ROCm CI Docker build process by marking the copied repository directory as safe. The issue occurs when the git repository is fetched with one UID and then copied into the Docker image with a different UID, causing git commands to fail and resulting in incorrect wheel versioning (defaulting to 0.0.0).
Changes:
- Added a git configuration command to mark
/root/flashinferas a safe directory in the ROCm CI Dockerfile
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rocm ci build system fetches the git repo separately and then copies it into the final docker image. Both steps use different uids that causes git to fail inside the docker image due to invalid directory ownership issues. A corollary of
gitfailing is that our wheel versioning that depends ongit describefails and we end up with0.0.0as the fallback version.The PR adds a
RUN git config --global --add safe.directory /root/flashinferstep in our CI docker file to temporarily workaround the issue.