Skip to content

Fix conda install on distributions with strict POSIX sh#18

Merged
jithunnair-amd merged 1 commit intomainfrom
builder-conda-bash
Jan 24, 2023
Merged

Fix conda install on distributions with strict POSIX sh#18
jithunnair-amd merged 1 commit intomainfrom
builder-conda-bash

Conversation

@jataylo
Copy link

@jataylo jataylo commented Jan 18, 2023

We require the same fix that was made on upstream pytorch pytorch/pytorch#91371
ROCm/pytorch@b72ec7c

Without this change install_conda.sh stage fails

#21 6.254 CondaFileIOError: '/opt/conda/pkgs/envs/*/env.txt'. [Errno 2] No such file or directory: '/opt/conda/pkgs/envs/*/env.txt'
#21 6.254 
#21 ERROR: executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1
------
 > [conda 2/3] RUN bash ./install_conda.sh && rm install_conda.sh:
------
executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1

Locally tested with the /builder/libtorch/build_docker.sh

We require the same fix that was made on upstream pytorch
pytorch/pytorch#91371
ROCm/pytorch@b72ec7c

Without this change install_conda.sh stage fails
```
#21 6.254 CondaFileIOError: '/opt/conda/pkgs/envs/*/env.txt'. [Errno 2] No such file or directory: '/opt/conda/pkgs/envs/*/env.txt'
#21 6.254 
#21 ERROR: executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1
------
 > [conda 2/3] RUN bash ./install_conda.sh && rm install_conda.sh:
------
executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1
```

Locally tested with the `/builder/libtorch/build_docker.sh`
@jithunnair-amd jithunnair-amd merged commit fdad948 into main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants