VX_RPP 2.0 - Update rppCreate and rppDestroy APIs with Reordered Parameters#1486
Merged
kiritigowda merged 8 commits intoROCm:developfrom Feb 25, 2025
Merged
Conversation
Contributor
HazarathKumarM
commented
Feb 14, 2025
- Aligns Handle API Calls with RPP Handle Restructuring
- Changed the parameters order according to the updates mentioned in RPP PR#513
Collaborator
|
@HazarathKumarM - fails on our CI for now. What is the equivalent change in RPP? we have to merge that first into RPP to test this PR. |
rrawther
requested changes
Feb 15, 2025
Contributor
rrawther
left a comment
There was a problem hiding this comment.
MIVisionX has to check the RPP version to enable the new API changes. Otherwise we will fail in older RPP versions since APIs are different
Contributor
|
@kiritigowda The equivalent RPP PR is PR#513 |
Member
|
@kiritigowda CI passing after last 2 commits |
kiritigowda
approved these changes
Feb 25, 2025
kiritigowda
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.