Skip to content

VX_RPP 2.0 - Update rppCreate and rppDestroy APIs with Reordered Parameters#1486

Merged
kiritigowda merged 8 commits intoROCm:developfrom
HazarathKumarM:handle_restructure
Feb 25, 2025
Merged

VX_RPP 2.0 - Update rppCreate and rppDestroy APIs with Reordered Parameters#1486
kiritigowda merged 8 commits intoROCm:developfrom
HazarathKumarM:handle_restructure

Conversation

@HazarathKumarM
Copy link
Copy Markdown
Contributor

  • Aligns Handle API Calls with RPP Handle Restructuring
  • Changed the parameters order according to the updates mentioned in RPP PR#513

@kiritigowda
Copy link
Copy Markdown
Collaborator

@HazarathKumarM - fails on our CI for now. What is the equivalent change in RPP? we have to merge that first into RPP to test this PR.

FAILED: amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o 
/agent/_work/1/rocm/bin/amdclang++ -DAMD_FP16_SUPPORT -DENABLE_HIP=1 -DENABLE_OPENCL=0 -DRPP_AUDIO=1 -DRPP_BACKEND_HIP=1 -DUSE_PROF_API=1 -D__HIP_PLATFORM_AMD__ -D__HIP_PLATFORM_AMD__=1 -Dvx_rpp_EXPORTS -I/agent/_work/1/s/amd_openvx_extensions/amd_rpp/../../amd_openvx/openvx/include -I/agent/_work/1/s/amd_openvx_extensions/amd_rpp/include -I/agent/_work/1/rocm/include/rpp -isystem /agent/_work/1/rocm/include -O3 -DNDEBUG -fPIC -DGPU_SUPPORT=1 -DRPP_BACKEND_HIP=1 -DAUDIO_SUPPORT=1 -fdata-sections -std=gnu++14 -mavx2 -O3 -DNDEBUG -fPIC -std=gnu++14 -MD -MT amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o -MF amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o.d -o amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o -c /agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp
/agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp:2950:76: error: use of undeclared identifier 'RppBackend'
 2950 |             rppCreate(&handle->rppHandle, batchSize, 0, handle->hipstream, RppBackend::RPP_HIP_BACKEND);
      |                                                                            ^
/agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp:2953:77: error: use of undeclared identifier 'RppBackend'
 2953 |             rppCreate(&handle->rppHandle, batchSize, cpu_num_threads, NULL, RppBackend::RPP_HOST_BACKEND);
      |                                                                             ^
2 errors generated.
[225/314] Bui

Copy link
Copy Markdown
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIVisionX has to check the RPP version to enable the new API changes. Otherwise we will fail in older RPP versions since APIs are different

@shobana-mcw
Copy link
Copy Markdown
Contributor

@kiritigowda The equivalent RPP PR is PR#513

@r-abishek
Copy link
Copy Markdown
Member

@kiritigowda CI passing after last 2 commits

@kiritigowda kiritigowda requested a review from rrawther February 25, 2025 19:41
@kiritigowda kiritigowda changed the title Update rppCreate and rppDestroy APIs with Reordered Parameters VX_RPP 2.0 - Update rppCreate and rppDestroy APIs with Reordered Parameters Feb 25, 2025
@kiritigowda kiritigowda self-requested a review February 25, 2025 23:27
@kiritigowda kiritigowda merged commit c0e5142 into ROCm:develop Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:precheckin enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants