Merged
Conversation
f75961c to
4d75a97
Compare
This adds a .set_state() call (which would otherwise not be available as it's a provided method of the traits), which also benefits HAL users because the direct implementation can do without the branching of the provided method. Test pinouts are also provided for microbit-v2 because that's where it was just tested.
This is not a high quality implementation, but it satisfies the trait requirements.
641df2e to
24de1e3
Compare
Member
Author
|
It's complete enough that drivers can use it; let's ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To retain compatibility, we're actually adding an implementation of embedded-hal 1.0 in addition to the older 0.2 version.