maintainers.html: Add list of maintainers#141
Merged
miri64 merged 11 commits intoRIOT-OS:masterfrom Dec 9, 2024
Merged
Conversation
|
🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-141.surge.sh |
Member
Author
|
Currently only the default list of maintainers is rendered, as the token is not set for this PR (as it introduces the usage of this token). I tested it locally, but should we maybe at first not link maintainers.html in the menu and see if when merged to master the result is the correct one? |
waehlisch
previously approved these changes
Dec 8, 2024
Responsive grid
Update CODEOWNER explanation
Fix name in title
Fix explanation on background
Member
Author
|
Addressed comments, but we now need a re-ACK. |
Fix subtitle
Member
Author
Done. |
Masonry layout
Truncate full name if too long, use muted styling for full name
Fix fetching to not stringify "None"
leandrolanzieri
approved these changes
Dec 9, 2024
Collaborator
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good from my side!
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying a lot around to get a script running to add the list of maintainers to the documentation (see RIOT-OS/RIOT#21062 )1, @aabadie and I came to the conclusion that it might be best to have a dedicated service to generate the list and then somehow include the generated list into the documentation. All this generation-by-service-stuff, however, made me think: “We already have something like this: riot-os.org, our website, so why not just integrate the list of maintainers into our website?” So I did with this PR. All it takes was to change the access token for the deployment workflow.
Footnotes
Overall conclusion: reading teams needs a token with special permissions, generating the list as artifacts of a dedicated GitHub actions yields the list, but Murdock [and our doc building service] would again need a special GitHub token to download them. ↩