Skip to content

assets/pdfs: added Martine's master thesis#131

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:master
May 6, 2024
Merged

assets/pdfs: added Martine's master thesis#131
miri64 merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:master

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented May 2, 2024

Put the document on the web page for linking from the docs (https://doc.riot-os.org/group__net__gnrc.html - current link is down).

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2024

🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-131.surge.sh

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 3, 2024

There used to be also a slide set.

miri64
miri64 previously requested changes May 3, 2024
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the directory to assets/docs? assets/pdfs seems a little weird. Do only PDFs belong in their? What about other documents?

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented May 3, 2024

Can we rename the directory to assets/docs? assets/pdfs seems a little weird. Do only PDFs belong in their? What about other documents?

Personally, I don't care. So far, we only have PDFs and from the top of my head I don't see any other document format that I could imagine to share here. I don't have any objections, but I think that's also unrelated to this PR.

@chrysn
Copy link
Copy Markdown
Member

chrysn commented May 6, 2024

The assets folder is mixed in naming anyway between intention ("branding", "fonts") and technology ("css", "js"). Whatever we use (and I'm fine with either), let's just be aware that this is a potential deep linking target, and there is a stability promise associated with it [edit: to clarify: All URIs should be "Cool URIs", but I think that it goes especially for those other people may place links to. It may not matter for our style.css that is useless without the containing index.html, but once we add HTML, PDF or otherwise linkable resources, we should make an effort to not produce 404s down the line].

This only adds PDFs -- should there be a link there, transitively reachable from the root?

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2024

[…] from the top of my head I don't see any other document format that I could imagine to share here.

Hopefully some truly portable, non-proprietary document format in the future ;-).

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2024

but I think that's also unrelated to this PR.

You introduced this directory in this PR, so I would not call this unrelated to this PR.

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2024

After some offline discussions, @chrysn and I decided for pubs/ (for "publications") to keep it future-proof and distinguish from "documentation".

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 6, 2024

You introduced this directory in this PR, so I would not call this unrelated to this PR.

Ahhhh only now that I try to start moving things I realize that the directory already existed before this PR... I'd blame it on Git having no notion of a “new directory” but I could have looked it up... Sorry. Then nvm and sorry for the noise!

@miri64 miri64 dismissed their stale review May 6, 2024 12:45

Directory pdfs/ exited beforehand

@miri64 miri64 merged commit 04da9f1 into RIOT-OS:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants