Skip to content

CI: test for python 3.12 & fix linting error#3

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:py312
Jun 5, 2024
Merged

CI: test for python 3.12 & fix linting error#3
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:py312

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jun 5, 2024

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.84%. Comparing base (6b37837) to head (080ea07).
⚠️ Report is 3 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   98.85%   98.84%   -0.01%     
==========================================
  Files           1        1              
  Lines         261      259       -2     
  Branches       80       78       -2     
==========================================
- Hits          258      256       -2     
  Misses          1        1              
  Partials        2        2              
Flag Coverage Δ
3.10 98.84% <100.00%> (-0.01%) ⬇️
3.11 98.84% <100.00%> (-0.01%) ⬇️
3.12 98.84% <100.00%> (?)
3.7 98.80% <100.00%> (-0.01%) ⬇️
3.8 98.84% <100.00%> (-0.01%) ⬇️
3.9 98.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tool supposed to run in CI. Why do we bother with anything than latest Python in the first place?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My stance is: as long as it runs in those version, lets run it in those versions. People might need certain versions of python or whatever.

@miri64 miri64 merged commit ea0ec58 into RIOT-OS:master Jun 5, 2024
@miri64 miri64 deleted the py312 branch June 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants