examples, tests: Clean BOARD_* list in Makefiles#9983
examples, tests: Clean BOARD_* list in Makefiles#9983MrKevinWeiss wants to merge 8 commits intoRIOT-OS:masterfrom
Conversation
|
I still need to run through the blacklist and whitelist (tomorrow morning). Should we go for this until a better solution is out or should I just leave it in favor of #9081? |
|
@MrKevinWeiss thanks for tackling this! Honestly, I prefer the shorter representation (as it is now, as a short but wide block). How did you change the files? Maybe we can come up with some script? |
|
Ya I used a script but just quick and dirty python one (and looks pretty bad so I didn't want it merged). If you say no that is fine but every time I or someone adds a board they should push the rest of the boards down. Not the end of the world but seems unnecessary. Your call @kaspar030, I just wanted to follow through with what I said I will do when ACKing the blackpill board. |
|
Any other opinions on line count vs. editability here? @MrKevinWeiss how much work would it be to change your script to output blocks with line length < 80? |
|
@kaspar030 I would probably just rewrite but my goal is to have one line per board making future maintenance easier. Like I said if you feel strongly against it I am not going to push for this and we can close. |
|
@cladmi I would either like to (fix and) merge to close this PR. Can you throw in your two cents so we can make a decision? |
|
I'm just quoting my reason for preferring the "one board per line" option, hoping that it might get this merged :)
|
|
I re-arranged many applications that were not building for some boards and it was a pain. And one board per line does indeed help with this. But as there is a tool that may do this, I would say it could be better to merge it along with enabling the tool check in CI. |
|
Alright closing in favor of #10111 |
Contribution description
This PR rearranges the BOARD_INSUFFICIENT_MEMORY, BOARD_BLACKLIST and BOARD_WHITELIST to make add in new boards easier.
Testing procedure
Passes murdock and review.
Issues/PRs references
#9965