native: remove feature periph_gpio_irq#9976
Merged
haukepetersen merged 2 commits intoRIOT-OS:masterfrom Sep 20, 2018
Merged
Conversation
periph_gpio_irq
Contributor
|
To keep a working git history, the commits should be in the inverted order with disabling the feature before removing the code. |
As it is not implemented in the first place.
76a9832 to
a965532
Compare
Contributor
Author
|
changed order of commits |
cladmi
approved these changes
Sep 20, 2018
Contributor
cladmi
left a comment
There was a problem hiding this comment.
ACK waiting for murdock.
Github is still displaying them in the old order but it is a known issue with github displaying by 'author' date, checking locally displays the correct commit order.
Contributor
Author
|
All green -> go go go |
Closed
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
See #9974.
nativedoes not implement any GPIO irq features, so it should not declare that feature in the board, and also the function stubs are not longer needed.Testing procedure
Buildtest should suffice.
Issues/PRs references
#9974