drivers: Add missing dependencies#9844
Merged
aabadie merged 19 commits intoRIOT-OS:masterfrom Aug 27, 2018
Merged
Conversation
added 17 commits
August 26, 2018 08:09
aed9c4e to
5d4ee9d
Compare
0301498 to
667a43f
Compare
aabadie
approved these changes
Aug 27, 2018
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Good cleanup, thanks!
Code changes are ok and the CI have passed. ACK and go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Some drivers were missing dependencies on their periph interfaces or other modules. This PR fixes that problem. The issue was hidden by the tests/drivers_ applications defining FEATURES_REQUIRED even though it should not have been necessary.
Testing procedure
Any failures should show up in the linking phase, if the dependency is missing, the link will fail with missing symbols.
Issues/PRs references
none