pkg/jerryscript: many cleanups (split PRs)#9820
Closed
cladmi wants to merge 16 commits intoRIOT-OS:masterfrom
Closed
pkg/jerryscript: many cleanups (split PRs)#9820cladmi wants to merge 16 commits intoRIOT-OS:masterfrom
cladmi wants to merge 16 commits intoRIOT-OS:masterfrom
Conversation
Remove unknown rules from .PHONY. Make 'all' be the default target for jerryscript. This should trigger the normal 'DIRS' handling of Makefile.base.
Jerryscript was never using INCLUDES so never having the 'newlib-nano' or llvm includes.
This was referenced Aug 22, 2018
Contributor
Author
|
Clean fails if the directory does not exist, will fix. |
Contributor
Author
|
Found out I can replace the 'clean' things by just building in |
This reverts commit 069a065.
This reverts commit d1ff2f4.
This reverts commit e61deb6.
Build into the BINDIR directory instead of the source repository. This makes 'clean' work as expected without other intervention. Also it goes in the direction of having the package source repository board independant.
…le.base Do not include Makefile.base as 'DIRS' are not used here. Also if 'all' target was to be used, there would be two rules creating `$(BINDIR)/jerryscript.a`.
It does not trigger the DIRS anymore.
Member
|
@cladmi can you clarify: is this PR already split? Can this PR be closed then? |
Contributor
Author
|
Yes it is split, the goal was to have all PRs merged in the same place to verify that separate PRs still work together. But it is not needed anymore as issues have been resolved (except the esp support but that is something else). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When debugging jerryscript issues with llvm I noticed it was not finding
stdio.hon my arch linux computer:I found out that jerryscript was not using
INCLUDESand so not gettingnewlib-nanoandllvmincludes configuration.This PR also includes many other fixes and I can split it in separate PRs
It may even fix thestill does not work without it for ek-lm4f120xlHAVE_TIME_Hissue from #9808 should investigate more on how to test this one.Testing procedure
With gcc, we should get a 'nano' output that we don't have in master.
This fails on master with
stdio.hnot found on my computer.Issues/PRs references
#9809
#9808