kinetis: add support for S9KEAZ128#9666
Conversation
cpu/kinetis/vectors.c
Outdated
| #endif | ||
| #ifdef UART0 | ||
| #ifdef UART_RPL_RPL_MASK | ||
| # ifdef KINETIS_SINGLE_UART_IRQ |
There was a problem hiding this comment.
we might need to discuss and clarify (in coding conventions) how to indent pre-processor #ifs
There was a problem hiding this comment.
What would be your preferred indentation? Most of the code doesn't indent nested #ifs, but sometimes it gets too hard to read.
d1c227e to
992a191
Compare
smlng
left a comment
There was a problem hiding this comment.
also I currently get the following error when comping tests/periph_timer for the PhyNode (pba-d-01-kw2x) which has a Kinetis MCU, too:
/RIOT/cpu/kinetis/periph/timer.c:123:0: error: unterminated #ifdef
#ifdef KINETIS_HAVE_LPTMR
/RIOT/cpu/kinetis/periph/timer.c:85:14: error: 'pit' defined but not used [-Werror=unused-variable]
static pit_t pit[PIT_NUMOF];
^~~
/RIOT/cpu/kinetis/periph/timer.c:80:25: error: 'pit_config' defined but not used [-Werror=unused-const-variable=]
static const pit_conf_t pit_config[PIT_NUMOF] = PIT_CONFIG;
^~~~~~~~~~
cc1: all warnings being treated as errors
236a32d to
b0bf229
Compare
smlng
left a comment
There was a problem hiding this comment.
some minor things, still need to test this ...
ed4aee7 to
fcde6de
Compare
smlng
left a comment
There was a problem hiding this comment.
final (minor) changes, otherwise (very) close to merge ... will run some tests now, to verify it doesn't break any other Kinetis MCU/Board
|
CI is not happy, and for me it also fails with an error in periph/timer when compiling for PhyNode (pba-d-01-kw2x) |
|
ping @OYTIS, this needs to be in first, before we can get the KEA boards merged. |
35dbd00 to
19d2ef7
Compare
Signed-off-by: Anton Gerasimov <anton.gerasimov@here.com>
Signed-off-by: Anton Gerasimov <tossel@gmail.com>
|
@smlng |
|
I successfully tested with the PhyNode, just to make sure it doesn't break stuff for existing nodes. To me this looks good to go, so ACK & GO! |
|
@smlng Thanks a lot! I've rebased the next two PRs to make them more observable. |
Add supports for Kinetis EA series and S9KEAZ129 MCU.
This series is significantly different from K, for instance it uses different clock generation/distribution module and different pin multiplexing scheme. One might think it starts getting too far with conditional compilation already, maybe it's worth refactoring cpu/kinetis at some point to be more modular.