Skip to content

cflags: add -Wformat=2 -Wformat-overflow -Wformat-truncation [backport 2018.07]#9608

Closed
cladmi wants to merge 6 commits intoRIOT-OS:2018.07-branchfrom
cladmi:2018.07/pr/Wformat
Closed

cflags: add -Wformat=2 -Wformat-overflow -Wformat-truncation [backport 2018.07]#9608
cladmi wants to merge 6 commits intoRIOT-OS:2018.07-branchfrom
cladmi:2018.07/pr/Wformat

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Jul 19, 2018

Backport of #9355

Contribution description

Enables additional compile time checks for format strings used by printf, scanf, strftime.
Includes a fix for warnings in the (deprecated) sys/cbor module

Issues/PRs references

Related: #9243
Depends on: #9358, #9357

@cladmi cladmi added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 19, 2018
@cladmi cladmi requested a review from miri64 July 19, 2018 13:44
@cladmi cladmi mentioned this pull request Jul 19, 2018
Merged
miri64
miri64 approved these changes Jul 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jul 19, 2018

This is currently breaking with llvm so I will wait for another fix before merging.

@cladmi cladmi added the State: waiting for other PR State: The PR requires another PR to be merged first label Jul 19, 2018
@cladmi cladmi added State: waiting for other PR State: The PR requires another PR to be merged first and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 19, 2018
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jul 19, 2018

This depends on #9358 and #9612 they may not be included in the release. So this should still wait.

@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jul 25, 2018

I will close as it has dependencies that may not be integrated and it is only adding new warnings.

@cladmi cladmi closed this Jul 25, 2018
@cladmi cladmi added this to the Release 2018.07 milestone Aug 1, 2018
@cladmi cladmi deleted the 2018.07/pr/Wformat branch November 22, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master State: waiting for other PR State: The PR requires another PR to be merged first

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @miri64