net/nanocoap: add nanocoap_opt2 module#9474
Closed
kb2ma wants to merge 2 commits intoRIOT-OS:masterfrom
Closed
Conversation
Member
Author
|
@kaspar030, do you have any at least high-level reaction to this PR? I have asked @haukepetersen as part of moving forward on #8920, and I understand @bergzand would like to make a decision and move forward, too. |
Member
Author
|
This PR has gotten exactly zero traction from others, so closing for now. I don't want it to hold up other more important PRs like #9156. Perhaps we can revisit at a later date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
#9085 added a struct-based API to nanocoap for adding options to a CoAP message. This PR modularizes that work as nanocoap_opt2, and is the first step to moving all options functions into that context. There are a lot of functions related to options, and moving them to separate implementation files will make them easier to manage. The module in this PR also provides a mechanism to version options functions, so we can deprecate the original function names in favor of a more structured naming scheme.
The idea is to organize options functions like this:
opt2_add.copt2_put.copt2.cAlso begins to provide module-level documentation for nanocoap. Describes how to use the struct-based API, and contrasts with the traditional buffer-based API.
Issues/PRs references
Extends #9085