net/nanocoap: test coap_get_uri() boundaries#9444
Merged
kb2ma merged 1 commit intoRIOT-OS:masterfrom Jun 28, 2018
Merged
Conversation
smlng
approved these changes
Jun 28, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
Looks good, tested ACK. Though I feel there is (much) room for lots of code deduplication here - or in unittests in general, but that's another PRs work 😄
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Adds unit tests for retrieval of large and small URI paths via coap_get_uri(). See PR comment for motivation.
Issues/PRs references
Supports #9156.