Skip to content

sam0_common/i2c.c extra byte fix#9257

Closed
MrKevinWeiss wants to merge 3 commits intoRIOT-OS:new_i2c_iffrom
MrKevinWeiss:pr/sam0_common/i2c_fix
Closed

sam0_common/i2c.c extra byte fix#9257
MrKevinWeiss wants to merge 3 commits intoRIOT-OS:new_i2c_iffrom
MrKevinWeiss:pr/sam0_common/i2c_fix

Conversation

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss commented May 31, 2018 •
edited
Loading

Contribution description

This PR provides a workaround for the SAMR I2C reading an extra byte (based on hardware defined in datasheet page 513 or 514). It also is updates the return values to the error code in the API rework. It is based off of @dylad PR #9198 and is needed for the periph_i2c in PR #9168 to test it. That only file that was worked on when diff with #9198 is the cpu/sam0_common/periph/i2c.c

Issues/PRs references

Issue: #6577
Based from #9198
Needed for #9168
samr21 datasheet

@MrKevinWeiss MrKevinWeiss added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. TF: I2C Marks issues and PRs related to the work of the I²C rework task force Area: cpu Area: CPU/MCU ports labels May 31, 2018
@MrKevinWeiss
Copy link
Copy Markdown
Contributor Author

MrKevinWeiss commented May 31, 2018

This doesn't have to be merged, just want to make sure @dylad doesn't have to go through the trouble I did getting this to function properly and have something that can be used with the #9168.

@MrKevinWeiss MrKevinWeiss changed the title Pr/sam0 common/i2c fix pr/sam0 common/i2c fix May 31, 2018
@MrKevinWeiss MrKevinWeiss changed the title pr/sam0 common/i2c fix sam0_common/i2c.c extra byte fix May 31, 2018
@MrKevinWeiss MrKevinWeiss mentioned this pull request May 31, 2018
Merged
@dylad
Copy link
Copy Markdown
Member

dylad commented May 31, 2018

Give it a quick look, some parts are dirty. I'm sure we can improve it AND support NOSTART NOSTOP.
I'll work on it whenever I find some time.

@MrKevinWeiss
Copy link
Copy Markdown
Contributor Author

MrKevinWeiss commented Jun 3, 2018

Closed in favor of #9198

@MrKevinWeiss MrKevinWeiss deleted the pr/sam0_common/i2c_fix branch June 8, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@dylad dylad Awaiting requested review from dylad

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. TF: I2C Marks issues and PRs related to the work of the I²C rework task force Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrKevinWeiss @dylad @smlng