sys/embunit: Fix incompatible declaration in outputter.#9242
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom May 31, 2018
Merged
sys/embunit: Fix incompatible declaration in outputter.#9242miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
OutputterPrintHeaderFunction is declared as a function of 1 parameter but CompilerOutputter_printHeader was defined as taking 2. It is a mystery why this code compiled before.
miri64
approved these changes
May 30, 2018
Member
miri64
left a comment
There was a problem hiding this comment.
ACK, if possible provide upstream?
Member
|
If anyone hits the merge button before myself, please check if the unittests actually ran on Murdock ;-). |
Member
|
Fail is unrelated, but unittests did not run (see #9249) |
Member
Ah, it's hidden in here: https://ci.riot-os.org/RIOT-OS/RIOT/9242/40e58a1afc8a9a797a1f0b7fcd955e3506d2b540/output/compile/tests/unittests/native.txt |
Contributor
Author
|
@miri64 embunit does not seem to be actively developed anymore. The "official" code is in a CVS repo on SourceForge, if that says something. The last file upload is from 2004!!!!! |
Member
|
Yeah... I thought there might be some GitHub repo that picked it up, but I seem to have been mistaken :/ |
This was referenced Jul 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
OutputterPrintHeaderFunctionis declared as a function of one parameter butCompilerOutputter_printHeaderwas defined as taking two. Thus the compiler rightly issues a warning:It is a mystery why this code compiled before.