pkg/relic: Fix warning caused by -Wsizeof-pointer-memaccess.#9241
Closed
jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
pkg/relic: Fix warning caused by -Wsizeof-pointer-memaccess.#9241jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
The fix has already been PR'd upstream. In the meanwhile, we need to be able to keep on compiling.
Contributor
Author
|
The fix got merged upstream. Should I instead update relic's version? |
Member
|
IMO it's better to use a corrected upstream than to maintain our own patch set, but I don't know anything about the relic package. |
Member
|
ping @tfar |
Contributor
|
Ah...forgot about this. Will take a look at this today. |
Member
|
ping @tfar |
Member
Member
|
ping @jcarrano - ready to close? |
Contributor
Author
|
Closing, my patch is already merged upstream, and riot is using latest upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix has already been PR'd upstream.
In the meanwhile, we need to be able to keep on compiling.The PR has been mergedContribution description
GCC's -Wsizeof-pointer-memaccess (activated by -Wall) checks calls of the form
And emits a warning if X does not seem to make sense. In Relic, src = X= a constant string and this triggers gcc's warning, which gets converted into an error.
I'm using GCC 8.1.0.
Issues/PRs references
Upstream pr: relic-toolkit/relic#78