cpu/lpc2387: Fixed broken SPI driver#9154
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom May 21, 2018
Merged
Conversation
aabadie
reviewed
May 19, 2018
cpu/lpc2387/periph/spi.c
Outdated
| /* power on */ | ||
| PCONP |= (PCSSP0); | ||
|
|
||
| spi_init_pins(bus); |
Contributor
There was a problem hiding this comment.
This seems weird to have gpio initialization in the spi_aquire function. Could it be kept in spi_init ?
Member
Author
There was a problem hiding this comment.
It seems to still work - I tested sending 100 pings and got 100 matching pongs :-)
This PR is updated with the pin initialization moved back to spi_init
In commit 513b20f the SPI API was changed to power up an configure the SPI bus on spi_acquire(). Sadly, the lpc2387 SPI apparently needs to be reconfigured after each power up. This commit moves the initialization code required after each power up from spi_init() to spi_acquire().
Contributor
Very nice ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 513b20f the SPI API was changed to
power up an configure the SPI bus on spi_acquire(). Sadly, the lpc2387 SPI
apparently needs to be reconfigured after each power up. This commit moves
the initialization code from spi_init() to spi_acquire() and restores the
order of initialization steps as before said commit.
With this commit, the CC1100 transceiver of the MSBA2 board becomes usable
again.
This fixes Issue #6857