newlib-nano: add include directory#9080
Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom May 27, 2018
Merged
Conversation
The newlib-nano include directory can be named either newlib-nano or nano, so we should make sure it is added in both cases.
Member
|
@gebart @kaspar030 ready for approval? |
Contributor
|
I'm sorry to come until now, but this PR broke compilation for ARM platforms on OS X. I'll investigate for a solution. |
Contributor
|
@smlng @emmanuelsearch can you verify just to check if it's not only my local setup? |
Contributor
|
This PR broke compilation in ArchLinux. As far as I can tell, it's not really the fault of this change, but rather the newlib package in Arch is not installing the nano directory properly (see https://bugs.archlinux.org/task/50481 reported by someone at OTAkeys). @kYc0o Maybe in OSX there is a similar problem. As a workaround, can we fall back to what we were doing previousl if neither the "nano" or "newlib-nano" directories are found? |
Contributor
Member
Author
|
I found a more elegant way to fix the issue. See #9216. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
In libnewlib-arm-none-eabi version 2.4.0.20160527-3 the include directory is called nano iso newlib-nano. This fix checks for the existence of either directories and adds it to the include path.