net/gcoap: increase stack size by sizeof(coap_pkt_t)#8998
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Apr 23, 2018
Merged
net/gcoap: increase stack size by sizeof(coap_pkt_t)#8998kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
@miri64 could you quickly check that this fixes your problem? |
kb2ma
approved these changes
Apr 23, 2018
Member
kb2ma
left a comment
There was a problem hiding this comment.
This update worked for me on samr21-xpro. Available stack size increased from 1024 to 1240. Used stack initially was 788, and increased to 1116 after sending a message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Apparently the latest nanocoap rework had side effects on gcoap's stack usage, and not of the good kind.
This PR adds
sizeof(coap_pkt_t)to the gcoap stacksize. Meant as quickfix for the release, better solution is on its way.Issues/PRs references
Fixes #8981.