Skip to content

kinetis: Refactor RTT driver#8930

Merged
kYc0o merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/kinetis-rtt-refactor
May 30, 2018
Merged

kinetis: Refactor RTT driver#8930
kYc0o merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/kinetis-rtt-refactor

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

Contribution description

  • Keep counter value between resets
  • Let kinetis_mcg_init manage the RTC oscillator, to avoid disrupting the core clock in certain configurations
  • Remove some unnecessary macros for hardware abstraction; all Kinetis CPUs which have an RTC only have a single RTC instance, and the ISRs and hardware registers are named the same way in all Kinetis CPU headers.

Issues/PRs references

Depends on #8928

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: timers Area: timer subsystems labels Apr 11, 2018
@jnohlgard jnohlgard added this to the Release 2018.07 milestone Apr 11, 2018
@jnohlgard jnohlgard requested a review from kYc0o April 11, 2018 18:43
@jnohlgard jnohlgard force-pushed the pr/kinetis-rtt-refactor branch 3 times, most recently from 70c016f to 51683d2 Compare April 13, 2018 13:38
@jnohlgard jnohlgard force-pushed the pr/kinetis-rtt-refactor branch from 51683d2 to c6284ae Compare April 18, 2018 09:32
@jnohlgard
Copy link
Copy Markdown
Member Author

Rebased after #8928 was merged

@jnohlgard jnohlgard force-pushed the pr/kinetis-rtt-refactor branch from ad4ae89 to e1b0993 Compare April 25, 2018 06:37
Joakim Nohlgård added 3 commits May 22, 2018 16:46
- Keep counter value between resets
- Let kinetis_mcg_init manage the RTC oscillator, to avoid disrupting
  the core clock in certain configurations
- Remove some unnecessary macros for hardware abstraction; all Kinetis
  CPUs which have an RTC only have a single RTC instance, and the ISRs
  and hardware registers are named the same way in all Kinetis CPU
  headers.
@jnohlgard jnohlgard force-pushed the pr/kinetis-rtt-refactor branch from e1b0993 to 31cf342 Compare May 22, 2018 14:47
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK. I tested it on kw41z, k64f and mulle with success.

@kYc0o kYc0o merged commit 9a0f346 into RIOT-OS:master May 30, 2018
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented May 30, 2018

Well, this PR was also touching periph_conf files that will probably be changed with I2C rework... Why not waiting ?

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented May 30, 2018

I think what we need is a certitude that the embargo is also in place for any change on all the periph_conf files. Therefore, if that's the case, we urge to have the I2C branch in really super fast, otherwise we block more than a half of the current PRs.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented May 30, 2018

You just have to look in the periph_conf if there's already some I2C configured, which was the case here. I think @gebart will probably take the I2C rework opportunity for updating old style (using defines) to new style (using array of struct) I2C configuration.
Unfortunately, the I2C configuration is just above the RTT config so there's a high chance that it will raise a conflict.

we urge to have the I2C branch in really super fast, otherwise we block more than a half of the current PRs

+1. So what are we waiting for ?

@jnohlgard
Copy link
Copy Markdown
Member Author

I think I will cherry pick these kinetis PRs into my kinetis i2c branch and it will be automatically resolved when we rebase the new_i2c_if branch

@jnohlgard jnohlgard deleted the pr/kinetis-rtt-refactor branch June 8, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants