dist/tools: jlink: use GDB as default for DBG#8853
Merged
basilfx merged 1 commit intoRIOT-OS:masterfrom Mar 30, 2018
Merged
Conversation
jnohlgard
approved these changes
Mar 29, 2018
Member
jnohlgard
left a comment
There was a problem hiding this comment.
Looks fine as a remedy for the immediate symptom. The jlink script would benefit from the same refactoring as the openocd script, but someone will need to do the actual work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I'm not sure when exactly, but suddenly
make debugdidn't work for JLink-based targets, unless you specifyDBG. I therefore created #7904.Today, I compared
jlink.shwithopenocd.sh, and I noticed that OpenOCD defaults to theGDBvariable ifDBGis undefined. This PR will now do the same for JLink. I'm not a shell-script expert, so I have no intentions to rewrite/refactor the script, but this easy fix does it.Issues/PRs references
This comment