cpu/stm32: unify cpu_init()#8735
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Mar 6, 2018
Merged
Conversation
80edbc0 to
3b42fb4
Compare
Contributor
|
Very nice ! |
Contributor
Looking at the code, the stmclk.c of stm32l4 hasn't been merged with other |
Contributor
|
Just to keep track of the testing on cpu family boards:
|
aabadie
approved these changes
Mar 6, 2018
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Tested on all stm32 cpu families, all worked. I have no comment on the code changes, they are all fine.
ACK
Contributor
|
I let @haukepetersen a chance to review this, just in case. |
Contributor
Author
True, I missed that file. But it seems to have quite some differences, thus it'll have to go folo. |
Contributor
|
all green -> go go go |
This was referenced Apr 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
stm32's cpu.c look the same on all stm32fx and stm32l4, and almost identical for stm32l0&1.
This PR unifies accordingly.