Skip to content

tests/fatfs: Fix tests on native after configuration changes in #8272#8614

Merged
jnohlgard merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/tests-pkg_fatfs-mtd-fix
Feb 26, 2018
Merged

tests/fatfs: Fix tests on native after configuration changes in #8272#8614
jnohlgard merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/tests-pkg_fatfs-mtd-fix

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

Contribution description

We forgot to update the name of the configuration variables in the Makefiles for the FatFs test applications when merging #8272. Without this fix, the test applications fail at run time with various error codes.

Steps to reproduce the issue

cd tests/pkg_fatfs_vfs
export BOARD=native
make image
make
make term

Results

on current master:

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
Native RTC initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2018.04-devel-311-g745f1-cheesecake)
Tests for FatFs over VFS - test results will be printed in the format test_name:result
test_mount__mount:[FAILED]
test_mount__umount:[FAILED]
test_open__mount:[FAILED]
test_open__open:[OK]
test_open__open_ro:[FAILED]
test_open__close_ro:[FAILED]
test_open__open_wo:[FAILED]
test_open__close_wo:[FAILED]
test_open__open_rw:[FAILED]
test_open__close_rw:[FAILED]
test_open__umount:[FAILED]
test_rw__mount:[FAILED]
test_rw__open_ro:[FAILED]
test_rw__read_ro:[FAILED]
test_rw__write_ro:[OK]
test_rw__close_ro:[FAILED]
test_rw__open_wo:[FAILED]
test_rw__read_wo:[OK]
test_rw__close_wo:[FAILED]
test_rw__open_rw:[FAILED]
test_rw__read_rw:[FAILED]
test_rw__write_rw:[FAILED]
test_rw__lseek:[FAILED]
test_rw__read_rw:[FAILED]
test_rw__close_rw:[FAILED]
test_rw__open_rwc:[FAILED]
test_rw__write_rwc:[FAILED]
test_rw__lseek_rwc:[FAILED]
test_rw__read_rwc:[FAILED]
test_rw__close_rwc:[FAILED]
test_rw__umount:[FAILED]
test_dir__mount:[FAILED]
test_dir__opendir:[FAILED]
Segmentation fault (core dumped)

with this PR:

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
Native RTC initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2018.04-devel-311-g745f1-cheesecake-pr/tests-pkg_fatfs-mtd-fix)
Tests for FatFs over VFS - test results will be printed in the format test_name:result
test_mount__mount:[OK]
test_mount__umount:[OK]
test_open__mount:[OK]
test_open__open:[OK]
test_open__open_ro:[OK]
test_open__close_ro:[OK]
test_open__open_wo:[OK]
test_open__close_wo:[OK]
test_open__open_rw:[OK]
test_open__close_rw:[OK]
test_open__umount:[OK]
test_rw__mount:[OK]
test_rw__open_ro:[OK]
test_rw__read_ro:[OK]
test_rw__write_ro:[OK]
test_rw__close_ro:[OK]
test_rw__open_wo:[OK]
test_rw__read_wo:[OK]
test_rw__close_wo:[OK]
test_rw__open_rw:[OK]
test_rw__read_rw:[OK]
test_rw__write_rw:[OK]
test_rw__lseek:[OK]
test_rw__read_rw:[OK]
test_rw__close_rw:[OK]
test_rw__open_rwc:[OK]
test_rw__write_rwc:[OK]
test_rw__lseek_rwc:[OK]
test_rw__read_rwc:[OK]
test_rw__close_rwc:[OK]
test_rw__umount:[OK]
test_dir__mount:[OK]
test_dir__opendir:[OK]
test_dir__readdir1:[OK]
test_dir__readdir2:[OK]
test_dir__readdir_name:[OK]
test_dir__readdir3:[OK]
test_dir__closedir:[OK]
test_dir__umount:[OK]
test_rename__mount:[OK]
test_rename__rename:[OK]
test_rename__opendir:[OK]
test_rename__readdir1:[OK]
test_rename__readdir2:[OK]
test_rename__check_name:[OK]
test_rename__readdir3:[OK]
test_rename__closedir:[OK]
test_rename__umount:[OK]
test_unlink__mount:[OK]
test_unlink__unlink1:[OK]
test_unlink__unlink2:[OK]
test_unlink__opendir:[OK]
test_unlink__readdir:[OK]
test_unlink__closedir:[OK]
test_unlink__umount:[OK]
test_mkrmdir__mount:[OK]
test_mkrmdir__mkdir:[OK]
test_mkrmdir__opendir1:[OK]
test_mkrmdir__closedir:[OK]
test_mkrmdir__rmdir:[OK]
test_mkrmdir__opendir2:[OK]
test_mkrmdir__umount:[OK]
test_create__mount:[OK]
test_create__open_wo:[OK]
test_create__write_wo:[OK]
test_create__close_wo:[OK]
test_create__umount:[OK]
Test end.

Issues/PRs references

Bug was introduced by #8272

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: fs Area: File systems labels Feb 22, 2018
@jnohlgard jnohlgard added this to the Release 2018.04 milestone Feb 22, 2018
@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 26, 2018
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, verified by testing myself.

Copy link
Copy Markdown
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jnohlgard jnohlgard merged commit 032b07c into RIOT-OS:master Feb 26, 2018
@jnohlgard jnohlgard deleted the pr/tests-pkg_fatfs-mtd-fix branch February 26, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: fs Area: File systems Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants