emb6: allow for warnings to be disabled#8571
Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom Feb 16, 2018
Merged
Conversation
Currently, due to the way emb6 is compiled in our build system, it is not possible to deactivate certain warnings. This fix provides a solution for that, by building the submodules in the package build step instead of on their own, similar to how JerryScript is build.
This allows for easier maintainance of the package, since smaller patches lead to less conflicts when applying these patches.
5531eb4 to
388d8ab
Compare
Member
|
nice! |
Member
Author
|
Build error looks unrelated... |
kaspar030
reviewed
Feb 16, 2018
|
|
||
| INCLUDES += -I$(PKG_BUILDDIR)/target | ||
| INCLUDES += -I$(RIOTBASE)/pkg/emb6/include | ||
| INCLUDES += -I$(EMB6_DIR)/emb6 |
Contributor
There was a problem hiding this comment.
are these globally needed?
Member
Author
There was a problem hiding this comment.
Yes, either the application or auto_init (if we ever do that for emb6) need the emb6 headers to bootstrap the stack.
Member
yes it is, I was testing some new CI workers (with new packages versions) - didn't work out (yet), removed them again. I'll retrigger murdock ... |
f39601a to
388d8ab
Compare
smlng
approved these changes
Feb 16, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
looks good to me, tested with GCC 7.2 for arm-none-eabi and GCC 7.3 for AVR both with success.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently, due to the way emb6 is compiled in our build system, it is
not possible to deactivate certain warnings. This fix provides a
solution for that, by building the submodules in the package build step
instead of on their own, similar to how JerryScript is build.
Additionally, I piggy-backed to commits concerning warnings:
Issues/PRs references
See https://github.com/RIOT-OS/RIOT/pull/8430/files#r168480449