Skip to content

drivers/ina220: fix bus voltage range bitmask#8493

Merged
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
jia200x:ina220_fix
Jan 31, 2018
Merged

drivers/ina220: fix bus voltage range bitmask#8493
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
jia200x:ina220_fix

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Jan 30, 2018

Contribution description

This PR fixes wrong Bus Range bitmask in INA220 driver (see datasheet, P19). Also, fixes a wrong Doxygen reference to the ADC settings Table.

Issues/PRs references

Fixes #8262

Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked against data sheet, changes are correct

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 31, 2018
@PeterKietzmann PeterKietzmann merged commit 197abe8 into RIOT-OS:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bit Mask fixes in INA220.h

4 participants