boards+cc110x: introduce cc110x default config#8437
Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
boards+cc110x: introduce cc110x default config#8437miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
miri64
commented
Jan 25, 2018
boards/msba2/include/board.h
Outdated
| .cs = GPIO_PIN(1, 21), \ | ||
| .gdo0 = GPIO_PIN(0, 27), \ | ||
| .gdo1 = GPIO_PIN(1, 23), \ | ||
| .gdo2 = GPIO_PIN(0, 28) } |
Member
Author
There was a problem hiding this comment.
I've taken these ports from the schematics linked on the MSBA2 wiki page. This checks out with the values found in the original definition when you run them through the expression GPIO_PIN() evaluates to.
f2b9cbf to
ee0728a
Compare
Member
Author
|
Rebased and moved to new definition scheme as defined there. |
ee0728a to
e2a3b35
Compare
Contributor
|
please squash! |
* Moves board specific cc110x_params.h to driver (as with other drivers) * Modernizes MSBA2 cc110x config (the only board-specific cc110x config)
e2a3b35 to
eca946a
Compare
Member
Author
|
Squashed! |
Member
|
@kaspar030 any feedback or is this ready for approval? |
Contributor
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing #8061 I noticed, that the
cc110xdriver doesn't have a default config, like the other platforms have. So this:drivers)
Issues/PRs references
None