Skip to content

pkg/ccn-lite: bump version to fix compile error#8427

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pkg/ccnlite/bump_version
Feb 26, 2018
Merged

pkg/ccn-lite: bump version to fix compile error#8427
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pkg/ccnlite/bump_version

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 24, 2018 •
edited by miri64
Loading

Contribution description

this PR updates the CCN-lite version to fix a compile issue found when using GCC 7.x and debug output, see here:

/RIOT/examples/ccn-lite-relay/bin/pkg/native/ccn-lite/src/ccnl-fwd/src/ccnl-dispatch.c:94:36: error: format '%zd' expects argument of type 'signed size_t', but argument 5 has type 'int' [-Werror=format=]
             DEBUGMSG_CORE(WARNING, "?unknown packet format? ccnl_core_RX ifndx=%d, %d bytes starting with 0x%02x at offset %zd\n",
                                    ^
                      ifndx, datalen, *data, data - base);
                                             ~~~~~~~~

I made a PR on the upstream repo of CCN-lite which is already merged, hence this PR update the package version accordingly.

Issues/PRs references

for GCC7 compatibility see #8265, fixes #8627

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Jan 24, 2018
@smlng smlng added this to the Release 2018.01 milestone Jan 24, 2018
@smlng smlng requested a review from cgundogan January 24, 2018 12:15
@smlng smlng force-pushed the pkg/ccnlite/bump_version branch from 76b7309 to 20e728b Compare January 24, 2018 14:02
@smlng smlng mentioned this pull request Jan 24, 2018
Merged
@smlng smlng requested a review from PeterKietzmann January 25, 2018 10:07
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jan 30, 2018

can you please adjust the ccn-lite version, again?

@smlng smlng removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 30, 2018
@smlng smlng force-pushed the pkg/ccnlite/bump_version branch from 20e728b to 2df10d4 Compare February 2, 2018 09:52
@smlng smlng force-pushed the pkg/ccnlite/bump_version branch from 2df10d4 to 0f871ad Compare February 2, 2018 09:54
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 2, 2018

@cgundogan done

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 13, 2018

What's missing here? @cgundogan do you ACK?

@jnohlgard jnohlgard mentioned this pull request Feb 19, 2018
Closed
13 tasks
@smlng smlng mentioned this pull request Feb 26, 2018
Closed
@miri64 miri64 mentioned this pull request Feb 26, 2018
Closed
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 26, 2018

This fixes #8627 for me, so ACK from my side.

@miri64 miri64 merged commit dbbf18a into RIOT-OS:master Feb 26, 2018
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 26, 2018

Gnarf, should have triggered a rebuild, let's hope I did not break anything by merging this 1-line change ^^"

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 26, 2018

🤞

@smlng smlng deleted the pkg/ccnlite/bump_version branch June 29, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

ccn-lite: does not build on Ubuntu 16.04 (LTS)

4 participants

@smlng @cgundogan @kYc0o @miri64